unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Felician Nemeth <felician.nemeth@gmail.com>
To: 58893@debbugs.gnu.org
Subject: bug#58893: 29.0.50; Feedback on Eglot manual
Date: Sun, 30 Oct 2022 10:42:45 +0100	[thread overview]
Message-ID: <874jvlk5pm.fsf@betli.tmit.bme.hu> (raw)

All in all, I think the new eglot.texi is really informative.
Nevertheless, having reread Eglot's github page, I've found some
information that's missing from the manual.  Maybe it's worth including
some of them to the manual.

* Missing commands

I'm not sure whether it is necessary to document all the commands
defined by Eglot, but the manual mentions xref-find-definitions, so
probably it should call the reader's attention to
eglot-find-declaration, eglot-find-implementation,
eglot-find-typeDefinition, and xref-find-references as well.


* WorkspaceFolders

The LSP protocol supports multiple workspace folders.  Eglot relies on
project-external-roots to get the additional folders (besides
project-root).  This is not mentioned in the manual.  However, (info
"(emacs)Projects") doesn't talk about how the user should configure
these external roots.

Maybe a simple solution is to rework the relevant part from NEWS.md into
the eglot.texi. NEWS.md has this:

   Eglot now advertises project-root and project-external-roots as
   workspace-folders. (Configuring tags-table-list sets the external
   roots of a simple git project.)


* Snippet completion

Yasnippet should be enabled in the current buffer before Eglot connects
to the LSP server.


Thanks.





             reply	other threads:[~2022-10-30  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  9:42 Felician Nemeth [this message]
2022-10-30 10:29 ` bug#58893: 29.0.50; Feedback on Eglot manual Eli Zaretskii
2022-10-30 14:15   ` Felician Nemeth
2022-11-02  8:26   ` João Távora
2022-11-06 19:15     ` Felician Nemeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jvlk5pm.fsf@betli.tmit.bme.hu \
    --to=felician.nemeth@gmail.com \
    --cc=58893@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).