From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 59351@debbugs.gnu.org
Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry
Date: Fri, 18 Nov 2022 19:42:16 +0800 [thread overview]
Message-ID: <874juwebfr.fsf@yahoo.com> (raw)
In-Reply-To: <8735agr0g4.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 18 Nov 2022 12:01:15 +0100")
Manuel Giraud <manuel@ledu-giraud.fr> writes:
> +struct glyph *x_y_to_hpos_vpos (struct window *, int, int, int *, int *,
> + int *, int *, int *);
Shouldn't this be "extern struct glyph *x_y_to_hpos_vpos ...?"
> + /* I guess this works because the menu bar is always
> + at position (0, 0) in a frame. Should this changed
> + and we need a way to calculate the correct position
> + into the menu bar from the position of the event in
> + the frame. */
I think this comment is unnecessary. Where else would a menu bar be?
next prev parent reply other threads:[~2022-11-18 11:42 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 8:37 bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Manuel Giraud
2022-11-18 10:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 11:01 ` Manuel Giraud
2022-11-18 11:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-18 12:10 ` Manuel Giraud
2022-11-18 13:19 ` Eli Zaretskii
2022-11-18 13:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 11:58 ` Eli Zaretskii
2022-11-18 12:15 ` Manuel Giraud
2022-11-18 12:29 ` Eli Zaretskii
2022-11-18 12:41 ` Manuel Giraud
2022-11-18 12:51 ` Eli Zaretskii
2022-11-18 13:12 ` Manuel Giraud
2022-11-18 13:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 13:40 ` Manuel Giraud
2022-11-18 14:08 ` Manuel Giraud
2022-11-18 14:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:31 ` Eli Zaretskii
2022-11-18 13:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 13:20 ` Manuel Giraud
2022-11-18 14:30 ` Eli Zaretskii
2022-11-18 15:20 ` Manuel Giraud
2022-11-18 15:26 ` Eli Zaretskii
2022-11-18 17:23 ` Manuel Giraud
2022-11-18 18:45 ` Eli Zaretskii
2022-11-21 13:40 ` Manuel Giraud
2022-11-21 14:23 ` Eli Zaretskii
2022-11-21 14:46 ` Manuel Giraud
2022-11-21 18:12 ` Eli Zaretskii
2022-11-22 0:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 16:43 ` Manuel Giraud
2022-11-23 17:31 ` Eli Zaretskii
2022-11-24 13:49 ` Manuel Giraud
2022-11-25 14:55 ` Manuel Giraud
2022-11-25 15:00 ` Manuel Giraud
2022-11-26 12:49 ` Eli Zaretskii
2022-11-26 17:26 ` Manuel Giraud
2022-11-26 17:38 ` Eli Zaretskii
2022-11-27 0:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-27 6:40 ` Eli Zaretskii
2022-11-28 17:07 ` Manuel Giraud
2022-11-29 0:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-29 8:00 ` Manuel Giraud
2022-11-29 9:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 10:30 ` Manuel Giraud
2022-11-29 12:14 ` Eli Zaretskii
2022-11-29 12:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 12:31 ` Eli Zaretskii
2022-12-01 16:23 ` Manuel Giraud
2022-12-01 16:50 ` Eli Zaretskii
2022-11-19 0:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-19 9:19 ` Manuel Giraud
2022-11-18 11:42 ` Eli Zaretskii
2022-11-18 12:12 ` Manuel Giraud
2022-11-18 12:26 ` Eli Zaretskii
2022-11-18 13:16 ` Manuel Giraud
2022-11-18 14:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874juwebfr.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=59351@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).