From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Date: Mon, 28 Nov 2022 14:40:20 -0800 Message-ID: <874jui1z57.fsf@ericabrahamsen.net> References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20298"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Sean Devlin , Helmut Eller , Stefan Monnier , 59345@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 23:41:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozmoL-00055z-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 23:41:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozmoC-0006qV-MQ; Mon, 28 Nov 2022 17:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozmoA-0006q2-P7 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozmoA-0008WL-Gy for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozmoA-0005g5-Dm for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs Original-Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166967523121809 (code B ref 59345); Mon, 28 Nov 2022 22:41:02 +0000 Original-Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 22:40:31 +0000 Original-Received: from localhost ([127.0.0.1]:51380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmne-0005fh-Nc for submit@debbugs.gnu.org; Mon, 28 Nov 2022 17:40:30 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:51190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmnc-0005fa-Kb for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 17:40:29 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E8948FA0BD; Mon, 28 Nov 2022 22:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669675222; bh=qT7SZdinne40Hvv8Myiq+LZ4yHpwAg6L5xRsJ6ehO9g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JbqZTLwIrCatSzvuFVpOsO6wBG7dLsUVGk8MiAQHPibcHNkntrmEqpTBL4rWx0JHX /3NeEAHWYTat5FUik2rW+1Mo5PZiqA6aMHPrjR3+TJowBJKxmlg3HBlSJmEcStthnU caELOiwQd/PI8kKcRfmp4wNgr27VwzZyCW7ijkTI= In-Reply-To: <87r0xnj9sl.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Nov 2022 08:58:18 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249346 Archived-At: --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Michael Heerdegen writes: > >> Helmut Eller writes: >> >>> >> In version 1.0 of peg.el, there is a PEX to match the syntax class of >>> >> the character at point. I expected it to advance the point after >>> >> recognizing the correct class, but it seems that it does not. >> >>> Yes, looks like an oversight. >>> [...] >>> I may be the original author (long ago), but the current maintainer is >>> Sefan Monnier. >> >> Ok, thanks for confirming, Helmut. Then I CC Stefan. > > I'm finally getting around to adding this package to core, so I'll > stick myself in the Cc. I guess the fix would look like the attached? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=peg_syntax_class.diff diff --git a/peg.el b/peg.el index 0e4221eeb7..3f86a0bf19 100644 --- a/peg.el +++ b/peg.el @@ -588,7 +588,9 @@ of PEG expressions, implicitly combined with `and'." (cl-defmethod peg--translate ((_ (eql syntax-class)) class) (let ((probe (assoc class peg-syntax-classes))) - (cond (probe `(looking-at ,(format "\\s%c" (cadr probe)))) + (cond (probe `(when (looking-at ,(format "\\s%c" (cadr probe))) + (forward-char) + t) (t (error "Invalid syntax class: %S\nMust be one of: %s" class (mapcar #'car peg-syntax-classes)))))) --=-=-=--