From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl Date: Tue, 20 Dec 2022 09:32:23 +0100 Message-ID: <874jtq79wo.fsf@thornhill.no> References: <87edsv7lc4.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32345"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com To: 60197@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 20 09:33:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Y4C-0008BE-R3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Dec 2022 09:33:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Y3u-0006Fp-6G; Tue, 20 Dec 2022 03:33:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Y3d-000690-IW for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 03:33:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7Y3a-0006nQ-St for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 03:33:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7Y3a-0000DV-CG for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2022 03:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Dec 2022 08:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60197 X-GNU-PR-Package: emacs Original-Received: via spool by 60197-submit@debbugs.gnu.org id=B60197.1671525155808 (code B ref 60197); Tue, 20 Dec 2022 08:33:02 +0000 Original-Received: (at 60197) by debbugs.gnu.org; 20 Dec 2022 08:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:43382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Y38-0000Cy-F3 for submit@debbugs.gnu.org; Tue, 20 Dec 2022 03:32:35 -0500 Original-Received: from out-220.mta0.migadu.com ([91.218.175.220]:29814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Y33-0000Cs-5X for 60197@debbugs.gnu.org; Tue, 20 Dec 2022 03:32:33 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671525147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iNkLWXIS0p4cdNyEIl3jE6mEa8HB/CVBKnbzTi6cY9E=; b=QbeulElqRW/d0uF0TVF00DPqXzjKglP6UPAg/8VUKNf5DuXkUdxX+TUTB5ye6+nkTLRAAS aUUoGJFp6hlbibhyDrXZBYCSomhjufYTJHqoMz+W5MTHI30bC9QXOv/64bVD6g7qESwy5/ nGRmhbpQF7s6kbvkb6HMlE1aBT/kRYNj43fa+9BG1YfhiY4zQF2uRMHkpXkSNX9P+AjaDY 31kbPTDb3SEPJ3+939urtqSvgG7Ovhz41i1ldToSUpF9f3COOqXUGN/5K0AYzBjCFmgowF chilru/jjSK/kmMyuMV6F74b+bAQ9AVV1o4ab21QCqjONKNa8ZwvadisSX0sog== In-Reply-To: <87edsv7lc4.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 19 Dec 2022 11:13:15 +0100") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251499 Archived-At: Theodor Thornhill writes: > Hi, Yuan! > > It seems 'prog-fill-reindent-defun' is broken after the latest changes > to treesit-beginning-of-defun. The culprit is that we now use remap > instead of setting the beginning-of-defun-function. What is the > reasoning behind that change? Can't we just rely on the variable > beginning-of-defun-function? > > I see you mentioned it is inteded to be used as a command, but surely > both should be possible? > This will also affect things like mark-defun and friends. Should I prepare a patch to fix this? Theo