From: "J.P." <jp@neverwas.me>
To: 60331-done@debbugs.gnu.org
Cc: Lele Gaifax <lele@metapensiero.it>, emacs-erc@gnu.org
Subject: bug#60331: 29.0.60; ERC 5.4.1: ERC cannot join channels without the networks module
Date: Wed, 28 Dec 2022 07:08:57 -0800 [thread overview]
Message-ID: <874jtfftva.fsf__32306.006136217$1672240235$gmane$org@neverwas.me> (raw)
In-Reply-To: <873592k987.fsf@neverwas.me> (J. P.'s message of "Sun, 25 Dec 2022 21:46:48 -0800")
"J.P." <jp@neverwas.me> writes:
> Tags: patch
>
> This is in reference to
>
> https://lists.gnu.org/archive/html/help-gnu-emacs/2022-12/msg00651.html
>
> which affects query buffers as well as channels in what will become ERC
> 5.5 (both Emacs 29 and HEAD). To reproduce from emacs -Q:
>
> (require 'erc)
> (setq erc-modules (remq 'networks erc-modules)) ; or delq even (ahem)
> (erc :server "127.0.0.1" :port 6667 :nick "tester")
>
> The attached patch tries to address this in a hopefully agreeable
> manner. Thanks.
This has been addressed in a slightly more responsible manner than that
originally proposed. In a pinch, third-party code can opt out of the
scary message by locally removing it from an internal hook during mode
or local-module setup (while ideally also alerting us to the need for a
public analog). If anyone takes issue with this approach or has a better
one in mind, please say so relatively soon. In the meantime, I'm closing
this bug report. Thanks.
next parent reply other threads:[~2022-12-28 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <873592k987.fsf@neverwas.me>
2022-12-28 15:08 ` J.P. [this message]
2022-12-26 5:46 bug#60331: 29.0.60; ERC 5.4.1: ERC cannot join channels without the networks module J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='874jtfftva.fsf__32306.006136217$1672240235$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=60331-done@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=lele@metapensiero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).