From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file Date: Sat, 28 Jan 2023 06:13:36 -0800 Message-ID: <874jsazqzz.fsf@neverwas.me> References: <87o7r5ji3q.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas To: 60730@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 28 15:14:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLlyI-00068o-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Jan 2023 15:14:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLly0-0004lM-Cm; Sat, 28 Jan 2023 09:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlxy-0004l2-MQ for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLlxy-0001cV-DU for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLlxx-0008Rs-Uz for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 09:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60730 X-GNU-PR-Package: emacs Original-Received: via spool by 60730-submit@debbugs.gnu.org id=B60730.167491523032448 (code B ref 60730); Sat, 28 Jan 2023 14:14:01 +0000 Original-Received: (at 60730) by debbugs.gnu.org; 28 Jan 2023 14:13:50 +0000 Original-Received: from localhost ([127.0.0.1]:39940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlxm-0008RI-2n for submit@debbugs.gnu.org; Sat, 28 Jan 2023 09:13:50 -0500 Original-Received: from mail-108-mta76.mxroute.com ([136.175.108.76]:40541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlxj-0008Qz-Eq for 60730@debbugs.gnu.org; Sat, 28 Jan 2023 09:13:48 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta76.mxroute.com (ZoneMTA) with ESMTPSA id 185f8ba0847000011e.001 for <60730@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 28 Jan 2023 14:13:39 +0000 X-Zone-Loop: 73a4ce613e2d93d353da9acfdaa530c1272e0ed3387a X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8/uo/t+N2M5fiUmUIhVWnSv0a6ezMXbaiBfo/SFNTtw=; b=d5H7H5uaC9nc8s50FWiu6JYDSr 8NjKNqdvtPjsvcquvcYpO34kBRSRrxb1mfjzs91uOcIMXwqkXSsEP6wvgXPNUJlMtojZTmYZxf0BK FeFs8xNE0S6+D1l3jm1if9oCubOkT/Gv/jN0Xo9wcAghFzmbQW4uONEPMrTfpPA9sEc9AVdX5Vlw6 bNir5N/KCtT6R93LA4CiBQMT8f0nrQA1FtwTIT5G2uz7izHvTPYuq0Tw59hO1J5dnkIQ89k3fcRFM uGjFibe98xZRrOHjESW8KH7Y7q0tRISuvEGtFEQd5qj1zZ6zE6XS6nThTSYMqCpOH+udlWa0oBPNu LGve8RzA==; In-Reply-To: (Stefan Kangas's message of "Thu, 12 Jan 2023 17:56:33 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254299 Archived-At: Perhaps I should have filed another report for this. It's a similar error in the same vicinity on the same branch, so I figured might as well piggyback. I'm getting "reference to free variable `utf-8'" warnings (from `elisp-flymake--batch-compile-for-flymake') when linting tests containing `ert-with-temp-file'. This doesn't show up if `coding-system-for-write' is nil or if you pass in a quoted keyword argument for `:coding'. Adding a quote like this seems to make it go away: diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el index 98a017c8a8e..70b136c5c55 100644 --- a/lisp/emacs-lisp/ert-x.el +++ b/lisp/emacs-lisp/ert-x.el @@ -484,7 +484,7 @@ ert-with-temp-file (suffix (or suffix ert-temp-file-suffix (ert--with-temp-file-generate-suffix (or (macroexp-file-name) buffer-file-name))))) - `(let* ((coding-system-for-write ,(or coding coding-system-for-write)) + `(let* ((coding-system-for-write ',(or coding coding-system-for-write)) (,temp-file (,(if directory 'file-name-as-directory 'identity) (make-temp-file ,prefix ,directory ,suffix ,text))) (,name ,(if directory Not sure if that's the right call, though. If this keyword is already seeing action in the wild, perhaps it's worth ensuring that its argument arrives unquoted? Or maybe another type check (to accompany the one for `name') would do? Thanks in advance.