From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, Vincenzo Pupillo <v.pupillo@gmail.com>,
61913@debbugs.gnu.org
Subject: bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java.
Date: Mon, 06 Mar 2023 07:12:49 +0100 [thread overview]
Message-ID: <874jqyo1b2.fsf@thornhill.no> (raw)
In-Reply-To: <83lekb8cba.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Mar 2023 17:09:29 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Vincenzo Pupillo <v.pupillo@gmail.com>
>> Date: Sun, 5 Mar 2023 14:50:39 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org>, 61913@debbugs.gnu.org
>>
>> nvim-treesiter seems to use a "lockfile" in which they put the version of the language parser to be installed
>> (https://github.com/nvim-treesitter/nvim-treesitter/blob/master/lockfile.json) to allow some stability I suppose.
>
> Those seem to be Git SHA hashes, but how can Emacs verify that the
> particular grammar shared library is of that revision or later? We
> can only tell users to verify that, which is not very reliable, and
> requires users to clone the repository.
We could keep a header in the *-ts-mode.el file maybe? Something like:
;;; Grammar version: 95e84b5493e8d21060f1a905d2e5e3c5590bae45
Anyway, I think until we have such a system in place, we should strive
to adhere to the most recent version of the grammar. The diff is ok,
Vicenzo. Would you like to add a proper patch or should I just do it?
I mean with a commit message and format like in CONTRIBUTE?
Theo
next prev parent reply other threads:[~2023-03-06 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 12:21 bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java Vincenzo Pupillo
2023-03-02 12:51 ` Vincenzo Pupillo
2023-03-02 13:01 ` Eli Zaretskii
2023-03-02 16:18 ` Vincenzo Pupillo
2023-03-03 22:32 ` Yuan Fu
2023-03-04 7:10 ` Eli Zaretskii
2023-03-04 9:27 ` Yuan Fu
2023-03-05 13:50 ` Vincenzo Pupillo
2023-03-05 15:09 ` Eli Zaretskii
2023-03-06 6:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-06 14:03 ` Vincenzo Pupillo
2023-03-09 10:24 ` Eli Zaretskii
2023-03-09 12:49 ` Vincenzo Pupillo
2023-03-09 15:28 ` Eli Zaretskii
2023-03-09 16:16 ` Dmitry Gutov
2023-03-09 16:49 ` Vincenzo Pupillo
2023-03-09 17:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jqyo1b2.fsf@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=61913@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=theo@thornhill.no \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).