From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Sat, 08 Apr 2023 09:06:28 +0000 Message-ID: <874jpq920b.fsf@posteo.net> References: <87zgb6uk2r.fsf@hyperspace> <87tu0tl1s4.fsf@hyperspace> <87a5zt2emd.fsf@betli.tmit.bme.hu> <87fs9l9bim.fsf@posteo.net> <87y1n3zsro.fsf@posteo.net> <871qku220f.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35154"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tony Zorman , 60418@debbugs.gnu.org, stefankangas@gmail.com To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 11:07:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl4XX-0008wm-2R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 11:07:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl4XI-0001rP-Cl; Sat, 08 Apr 2023 05:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl4XG-0001r4-EY for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 05:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pl4XG-00085i-5X for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 05:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pl4XF-0005Ig-On for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 05:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168094479820331 (code B ref 60418); Sat, 08 Apr 2023 09:07:01 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 8 Apr 2023 09:06:38 +0000 Original-Received: from localhost ([127.0.0.1]:57703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl4Ws-0005Hq-1X for submit@debbugs.gnu.org; Sat, 08 Apr 2023 05:06:38 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:38749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl4Wp-0005Hc-Qq for 60418@debbugs.gnu.org; Sat, 08 Apr 2023 05:06:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AFDAB240188 for <60418@debbugs.gnu.org>; Sat, 8 Apr 2023 11:06:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680944789; bh=sRVbyALxzG398GlnZSwzMDuWCrFUwo0Aj862v5kxPjQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Y+JthbuiKjwVc4TnlqP+D32BpowXdJlf7s8fUNO1QBxT6LH61VXf9YKwnFpgx8lbr LgGEMUKARTrVEvJxfQFh/d4HeJMbf6b1zns4sgNmM6EAyx2Vl/wJWLoNzGk4RnuWqp 3tDVzUxxQ5Zql9GwyookmGImWQ+EtHQUmOabxRRxc2vIjj7bCS6fprqdSD0LhpsxqO tcSf9kaT9IhDWsa7ABq7s6C18Z3qEj+icHpW3ys/Ace4Rz3zbtLGzyIlzhcCeBHjJA wLGTsCMBOPQ3eHiaJNpPhI3GA765C8VDuEkOnP19LXSgkOXaqExhWvMxsXRnSUKI81 csWLvRC4wA7HA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ptq9K0Mgpz6tw4; Sat, 8 Apr 2023 11:06:29 +0200 (CEST) In-Reply-To: <871qku220f.fsf@betli.tmit.bme.hu> (Felician Nemeth's message of "Sat, 08 Apr 2023 10:48:16 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259459 Archived-At: Felician Nemeth writes: >>>>> One has to keep in mind that by default you will be checking out the tip >>>>> of the default development branch. [...] > >>>> Maybe use-package's package-vc integration should use more sensible >>>> defaults then? But if people don't like this feature, I personally >>>> won't press the issue further. >>> >>> I am afraid I don't know what you mean by more sensible? My central >>> point is that I wouldn't want to encourage people to download packages >>> using package-vc by default. > > The integration of package-vc with use-package makes a bit easier what's > already possible. > > One possible way to mitigate the problem of running instable code is to > check out the commit with the latest tag. (I don't know how feasible is > to implement this.) package-vc can check out the latest revision that bumped the version tag (which is what {Non,}GNU ELPA uses to create new versions of a package), you just need to call `package-vc-install' with `:last-release' as REV. So the technical means are there. But if this is done, the question what advantage this has over just installing a tarball this has? You would almost always get the same code. > Alternatively, use-package cloud refuse a :vc > keyword if an additional :i-know-this-is-in-development-code keyword was > not set. Just to clarify, I am not vetoing anything here. If the functionality is added to use-package (which is up to the use-package maintainers to decide), then I don't think users need to be infantilized with these kinds of little ceremonies. All I want to understand is the motivation behind this feature in the first place. -- Philip Kaludercic