bug#63127: 29.0.90; Tramp all-completions errors with internal error

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Daniel Mendler]

I accidentally typed /sudo:::/ instead of /sudo::/ in the file
completion prompt of my Vertico completion UI. Vertico immediately
recomputes candidates and in this case shows an internal Tramp error.

File error: tramp-sh-handle-file-name-all-completions: internal error
accessing ‘/root/\:/’: ‘’

For reproduction, this internal error can be triggered by executing the
following expressions:

(all-completions "/sudo:::/" #'completion-file-name-table)
(try-completion "/sudo:::/" #'completion-file-name-table)

I am not sure if this can be considered a bug, certainly not a serious
one. Usually completion tables are supposed to not show such
internal errors. Instead they ideally just return nil signaling the
absence of matches. Maybe this indicates some problem in the Tramp file
handler parser, which could bail out earlier on such an invalid path?

Thanks!

Daniel

----

In GNU Emacs 29.0.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2023-04-27 built on projects
Repository revision: a40b1cba5ea53a780e9d3bb6b36e050dfa5e7c12
Repository branch: debundlemacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --prefix=/home/user/emacs/install --with-json
 --with-native-compilation --with-x-toolkit=athena --without-dbus
 --without-selinux --without-threads --without-gsettings --with-cairo'

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Michael Albinus]

Daniel Mendler <mail@daniel-mendler.de> writes:

Hi Daniel,

> I accidentally typed /sudo:::/ instead of /sudo::/ in the file
> completion prompt of my Vertico completion UI. Vertico immediately
> recomputes candidates and in this case shows an internal Tramp error.
>
> File error: tramp-sh-handle-file-name-all-completions: internal error
> accessing ‘/root/\:/’: ‘’
>
> For reproduction, this internal error can be triggered by executing the
> following expressions:
>
> (all-completions "/sudo:::/" #'completion-file-name-table)
> (try-completion "/sudo:::/" #'completion-file-name-table)

I'm not a vertico user, so I have tried to prepare Emacs for this. With
the following invocation, I could reproduce the bug:

--8<---------------cut here---------------start------------->8---
# ~/src/emacs-29/src/emacs -Q -l ~/.emacs.d/elpa/compat-29.1.4.1/compat-autoloads.el \
  -l ~/.emacs.d/elpa/vertico-1.2/vertico-autoloads.el -f vertico-mode
--8<---------------cut here---------------end--------------->8---

However, there exist a newer Tramp version in GNU ELPA. When I call

--8<---------------cut here---------------start------------->8---
# ~/src/emacs-29/src/emacs -Q -L ~/.emacs.d/elpa/tramp-2.6.0.3/ \
  -l ~/.emacs.d/elpa/compat-29.1.4.1/compat-autoloads.el \
  -l ~/.emacs.d/elpa/vertico-1.2/vertico-autoloads.el -f vertico-mode
--8<---------------cut here---------------end--------------->8---

the error doesn't happen. However, Vertico doesn't seem to complete at
all under this configuration.

Could you pls check, whether using Tramp 2.6.0.3 from GNU ELPA is still
compatible with Vertico? Note that we have changed Tramp's file name
completion per bug#37954, bug#51386, bug#52758, bug#53513, bug#54042 and
bug#60505 (all of them merged to one bug).

> I am not sure if this can be considered a bug, certainly not a serious
> one. Usually completion tables are supposed to not show such
> internal errors. Instead they ideally just return nil signaling the
> absence of matches. Maybe this indicates some problem in the Tramp file
> handler parser, which could bail out earlier on such an invalid path?

This sanity check has already been removed in Tramp 2.6.0.3 per bug#61890.

> Thanks!
>
> Daniel

Best regards, Michael.

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Daniel Mendler]

On 4/28/23 07:38, Michael Albinus wrote:
> However, there exist a newer Tramp version in GNU ELPA. When I call
> 
> --8<---------------cut here---------------start------------->8---
> # ~/src/emacs-29/src/emacs -Q -L ~/.emacs.d/elpa/tramp-2.6.0.3/ \
>   -l ~/.emacs.d/elpa/compat-29.1.4.1/compat-autoloads.el \
>   -l ~/.emacs.d/elpa/vertico-1.2/vertico-autoloads.el -f vertico-mode
> --8<---------------cut here---------------end--------------->8---

Yes, I am aware of the new Tramp version and the fixes regarding host
names and user names. I just tried to install it on Emacs 29 but I get
`tramp--with-startup' errors during initialization in emacs -Q - some
autoload issue. IOW I seem to be unable to test this.

> the error doesn't happen. However, Vertico doesn't seem to complete at
> all under this configuration.
> 
> Could you pls check, whether using Tramp 2.6.0.3 from GNU ELPA is still
> compatible with Vertico? Note that we have changed Tramp's file name
> completion per bug#37954, bug#51386, bug#52758, bug#53513, bug#54042 and
> bug#60505 (all of them merged to one bug).

Could you please be more specific about "complete at all"? Do you mean
no candidates are shown at all? I cc'ed Manuel Uberti. Afaik he tested
Tramp 2.6.0.3 (or the Tramp version on the Emacs master branch) with
Vertico and it works as expected. Maybe he can confirm that everything
is still functional?

>> I am not sure if this can be considered a bug, certainly not a serious
>> one. Usually completion tables are supposed to not show such
>> internal errors. Instead they ideally just return nil signaling the
>> absence of matches. Maybe this indicates some problem in the Tramp file
>> handler parser, which could bail out earlier on such an invalid path?
> 
> This sanity check has already been removed in Tramp 2.6.0.3 per bug#61890.

Thanks!

Daniel

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Daniel Mendler]

On 4/28/23 08:11, Daniel Mendler wrote:
> On 4/28/23 07:38, Michael Albinus wrote:
>> However, there exist a newer Tramp version in GNU ELPA. When I call
>>
>> --8<---------------cut here---------------start------------->8---
>> # ~/src/emacs-29/src/emacs -Q -L ~/.emacs.d/elpa/tramp-2.6.0.3/ \
>>   -l ~/.emacs.d/elpa/compat-29.1.4.1/compat-autoloads.el \
>>   -l ~/.emacs.d/elpa/vertico-1.2/vertico-autoloads.el -f vertico-mode
>> --8<---------------cut here---------------end--------------->8---
> 
> Yes, I am aware of the new Tramp version and the fixes regarding host
> names and user names. I just tried to install it on Emacs 29 but I get
> `tramp--with-startup' errors during initialization in emacs -Q - some
> autoload issue. IOW I seem to be unable to test this.

I tried again and this time I didn't install Tramp via package-install
but unpacked the tar manually. Then I could successfully load Vertico
and Tramp. Completing Tramp paths works fine with Vertico. I checked
that `tramp-version' is 2.6.0.3. Furthermore the /sudo:::/ issue is
gone. Feel free to close this bug!

However there seems to be an issue with Tramp and package installation
due to the `tramp--with-startup` macro. Not sure if I am the only one
affected by this.

Daniel

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Michael Albinus]

Daniel Mendler <mail@daniel-mendler.de> writes:

Hi Daniel,

> I tried again and this time I didn't install Tramp via package-install
> but unpacked the tar manually. Then I could successfully load Vertico
> and Tramp. Completing Tramp paths works fine with Vertico. I checked
> that `tramp-version' is 2.6.0.3. Furthermore the /sudo:::/ issue is
> gone. Feel free to close this bug!

Done.

> However there seems to be an issue with Tramp and package installation
> due to the `tramp--with-startup` macro. Not sure if I am the only one
> affected by this.

Well, there is bug#59194, waiting for action from me. I guess it is
related, so there's nothing left to do in *this* bug.

> Daniel

Best regards, Michael.

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Daniel Mendler]

On 4/28/23 13:01, Michael Albinus wrote:
>> However there seems to be an issue with Tramp and package installation
>> due to the `tramp--with-startup` macro. Not sure if I am the only one
>> affected by this.
> 
> Well, there is bug#59194, waiting for action from me. I guess it is
> related, so there's nothing left to do in *this* bug.

Yes, thanks!

Daniel

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 28/04/23 08:11, Daniel Mendler wrote:
> Could you please be more specific about "complete at all"? Do you mean
> no candidates are shown at all? I cc'ed Manuel Uberti. Afaik he tested
> Tramp 2.6.0.3 (or the Tramp version on the Emacs master branch) with
> Vertico and it works as expected. Maybe he can confirm that everything
> is still functional?

Yes, I can confirm everything still works as expected on the master branch.

-- 
Manuel Uberti
https://manueluberti.eu

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Michael Albinus]

Manuel Uberti <manuel.uberti@inventati.org> writes:

Hi Manuel,

>> Could you please be more specific about "complete at all"? Do you mean
>> no candidates are shown at all? I cc'ed Manuel Uberti. Afaik he tested
>> Tramp 2.6.0.3 (or the Tramp version on the Emacs master branch) with
>> Vertico and it works as expected. Maybe he can confirm that everything
>> is still functional?
>
> Yes, I can confirm everything still works as expected on the master branch.

This simply proves that I'm not able to use Vertico properly :-)

Thanks, and best regards, Michael.

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Daniel Mendler]

On 4/28/23 12:57, Michael Albinus wrote:
>>> Could you please be more specific about "complete at all"? Do you mean
>>> no candidates are shown at all? I cc'ed Manuel Uberti. Afaik he tested
>>> Tramp 2.6.0.3 (or the Tramp version on the Emacs master branch) with
>>> Vertico and it works as expected. Maybe he can confirm that everything
>>> is still functional?
>>
>> Yes, I can confirm everything still works as expected on the master branch.
> 
> This simply proves that I'm not able to use Vertico properly :-)

Vertico behaves like familiar menus in web browsers for example. In web
browsers, when you enter something in the address line, the recent URLs
are offered for selection. You can either submit your input or select
move up or down and then submit with RET. In Vertico with Tramp do you
see files offered for completion?

Daniel

bug#63127: 29.0.90; Tramp all-completions errors with internal error

[Michael Albinus]

Daniel Mendler <mail@daniel-mendler.de> writes:

Hi Daniel,

>> This simply proves that I'm not able to use Vertico properly :-)
>
> Vertico behaves like familiar menus in web browsers for example. In web
> browsers, when you enter something in the address line, the recent URLs
> are offered for selection. You can either submit your input or select
> move up or down and then submit with RET. In Vertico with Tramp do you
> see files offered for completion?

I haven't seen anything for completion. But honestly, I'm busy with
other bug fixing, so I trust your tests that there are no problems with
Tramp+Vertico interaction.

> Daniel

Best regards, Michael.