From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 12:32:17 +0000 Message-ID: <874jnno1bi.fsf@posteo.net> References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> <83pm6b5t1i.fsf@gnu.org> <878rczo28v.fsf@posteo.net> <83o7lv5sjc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: artscan@list.ru, 63757@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 14:33:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5mvA-0000p7-Fk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 14:33:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5mux-0004v1-Jv; Sun, 04 Jun 2023 08:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mut-0004l7-10 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:33:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5mus-0001WC-KP for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5mus-00084m-FZ for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168588194831002 (code B ref 63757); Sun, 04 Jun 2023 12:33:02 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 12:32:28 +0000 Original-Received: from localhost ([127.0.0.1]:45291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5muK-00083y-C2 for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:32:28 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:38549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5muH-00083j-80 for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 08:32:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A647D240103 for <63757@debbugs.gnu.org>; Sun, 4 Jun 2023 14:32:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685881938; bh=B9x/n5S7/dzCHv1X+N03MC9zzl0mLwyDIXbTJt0zAeQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Y1ERiXiMHdnRNU+NK/lkptK9Gt09Q5fLow7VAU33HaLnZs3BrylYaXvUXiz0w8aCq qbbe0ynpXs+sXQUaNRZFI56wz0gUtfTv97IVt4rD66bosK+CbnZQT+aAj3oxNd7S4z qeqS8SFR9AjyRm6I81e6oaQaPfgowhABlhOa8hWwWa2JzUwJ0MaiwZfl1fuYIa15+B SGaARuKXACrt9KekJS63a/flXGuVBQ8NZYqwq1smRfNYfhmI6R9U9deimew65Eb9uU qtDv83usQyg1xR9nay64I7zdS9r7MP+Ik5TV/ZZXSCX/n41kTJIpuGGpNcW9h9GwWW XyCjgkQFqZveQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QYx2T3WYlz6tx2; Sun, 4 Jun 2023 14:32:17 +0200 (CEST) In-Reply-To: <83o7lv5sjc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Jun 2023 15:19:19 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262945 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: artscan@list.ru, monnier@iro.umontreal.ca, 63757@debbugs.gnu.org >> Date: Sun, 04 Jun 2023 12:12:16 +0000 >> >> I'm sorry, that was the wrong patch -.- >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index de5108430aa..fdc09a939be 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -739,7 +739,7 @@ package-load-all-descriptors >> updates `package-alist'." >> (dolist (dir (cons package-user-dir package-directory-list)) >> (when (file-directory-p dir) >> - (dolist (pkg-dir (directory-files dir t "\\`[^.]" t)) >> + (dolist (pkg-dir (directory-files dir t "\\`[^.]")) >> (when (file-directory-p pkg-dir) >> (package-load-descriptor pkg-dir)))))) >> >> (I attached the *vc-diff* buffer, but before sending the message I >> invoked vc-diff again which modified the buffer contents. Should have >> just copied the diff manually...) > > Thanks, now it at least makes sense. > > But why does it matter whether the package directory names are sorted > or not? Is sorting package versions the same as sorting the names of > their directories? No, because directories are sorted by their names and by that metric, "foo-10" is less than "foo-9". But since package archives like MELPA use ISO 8601-like release-dates as version numbers, the order "works". If we disable sorting, the files returned in any order the operating system might have arbitrary stored the directory entries in which might even change depending on the file system. So at the very least we can argue that while sorting does not solve the issue, it provides a quick hack to prevent sudden breakage from Emacs 28 to Emacs 29, due to users relying on this kind of behaviour. A proper solution, that takes version numbers into account should be prepared on the master branch.