From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63842: 30.0.50; Slow 'gnus-summary-refer-thread' Date: Mon, 19 Jun 2023 17:44:37 +0200 Message-ID: <874jn3o3ru.fsf@ledu-giraud.fr> References: <871qiu6m1f.fsf@ledu-giraud.fr> <87bkhxl9th.fsf@ust.hk> <87ilc44r3u.fsf@ledu-giraud.fr> <831qiduv5f.fsf@gnu.org> <87352rr8vz.fsf@ledu-giraud.fr> <87fs6rashz.fsf@ust.hk> <87352ppwed.fsf@ledu-giraud.fr> <87ttv54myy.fsf@ust.hk> <87o7lco5dv.fsf@ledu-giraud.fr> <87bkhbpq1k.fsf@ust.hk> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 63842@debbugs.gnu.org, cohen@andy.bu.edu To: Andrew Cohen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 19 17:45:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBH4N-0009SR-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jun 2023 17:45:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBH4A-0008NR-Ra; Mon, 19 Jun 2023 11:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBH3w-0008BD-Rx for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 11:45:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBH3u-0001Ot-VL for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 11:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBH3u-0003D9-GE for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63842 X-GNU-PR-Package: emacs Original-Received: via spool by 63842-submit@debbugs.gnu.org id=B63842.168718948412293 (code B ref 63842); Mon, 19 Jun 2023 15:45:02 +0000 Original-Received: (at 63842) by debbugs.gnu.org; 19 Jun 2023 15:44:44 +0000 Original-Received: from localhost ([127.0.0.1]:57067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBH3b-0003CD-TS for submit@debbugs.gnu.org; Mon, 19 Jun 2023 11:44:44 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:25253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBH3Y-0003C3-M6 for 63842@debbugs.gnu.org; Mon, 19 Jun 2023 11:44:42 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=VfJADMgX v8oi4r2DcV8ZYv0dceWrZzRCtslQSr3mZCs=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=j6mOmqbDbsU3ub0lhLOgtDWYUcOn1L Cc7Ao9dkqTKEMoz6GuGCFo12dEupGKdN6rAtcP9qUNpBLD40gp0/xmAg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=VfJADMgXv8oi4r2D cV8ZYv0dceWrZzRCtslQSr3mZCs=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=h9vfxyTF0wa+tubb3QzSi9aB8O/kBLWn3QfzrN r0FmdxBQDYT8le73LIvqRF71KPB6thit1uw9mGgVU8iLEQiYFR19kJK/0okNXqyevL0Wbh NAPFoVCuYWCeWZ9YaeWqU/S5jKFtgjfOe5zUvzuera3CGDeeKc4RBzuoXyN49ZoO939gE2 bssr9V2v6YNaKwsfWLcbF0cb/JKdp1SPUq+6mSKqf9RrBboWd5DHnpXuiZh4Ww8BBvOeRD UgQoCcJ9zhXedY6HuomRsRVaeuaDipkLGeqG/D3yfKqBOJ0awKnofANEyC5Qr5PK09yucV xIKFfDNyhMdv2I0Pui8eJk6w== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 4f725805 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 19 Jun 2023 17:44:38 +0200 (CEST) In-Reply-To: <87bkhbpq1k.fsf@ust.hk> (Andrew Cohen's message of "Mon, 19 Jun 2023 20:58:15 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263688 Archived-At: Andrew Cohen writes: >>>>>> "MG" == Manuel Giraud writes: > > MG> Andrew Cohen writes: > >> OK, I think I understand the problem. > > [...] > > MG> From my tiny testing set, it does not seems to me that parsing > MG> all the headers is the way to go: the call to > MG> 'gnus-search-run-query' in gnus-search.el line 2206 directly > MG> returns direcly the correct set of messages and the call to > MG> 'gnus-get-newsgroup-headers-xover' later looks like some "deep" > MG> search (eg. on subject content). > > OK, I understand it now. This isn't really about searching, or subject > content (the fact that Manuel sees some articles not in the thread but > with similar subject remains a bit of a mystery). It is a mistery to me too. If 'gnus-get-newsgroup-headers-xover' job is to gather messages from the same thread, I think there is something wrong here. I'm still searching. > To get everything right, any articles in the thread that need to be > added to the summary buffer have to be added to the dependencies > hash. In the case of searching we know exactly which articles need to > be added so we have no need for 'gnus-read-all-available-headers to be > non-nil: the "found" articles are each added to the hash. The only > case where 'gnus-read-all-available-headers needs to be non-nil is > when we don't know exactly which articles are part of the thread in > which case we have to parse a larger set. This is what happens in the > 3rd case in the conditional (the "t" clause) in > 'gnus-summary-refer-thread. That is, this variable is only relevant in > those cases where we don't have a configured search engine and just > retrieve a lot of headers and hope for the best. So the setting of > 'gnus-read-all-available-headers is just in the wrong place. Thanks. I don't know for other backends/search engines but a binding of 'gnus-read-all-available-headers' to t elsewhere will sure fix my issue. -- Manuel Giraud