From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Mon, 24 Jul 2023 08:53:20 +0300 Message-ID: <874jlt7t4f.fsf@protesilaos.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64799@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 24 07:54:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNoWQ-0006Jc-7Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jul 2023 07:54:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNoWC-0000F7-MM; Mon, 24 Jul 2023 01:54:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNoWB-0000Ey-7Z for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 01:54:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNoWA-0006BZ-Vl for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNoWA-0004WK-34 for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 01:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jul 2023 05:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169017801317339 (code B ref 64799); Mon, 24 Jul 2023 05:54:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 24 Jul 2023 05:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:41524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNoVh-0004Vb-G7 for submit@debbugs.gnu.org; Mon, 24 Jul 2023 01:53:33 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:40253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNoVc-0004VK-5F for 64799@debbugs.gnu.org; Mon, 24 Jul 2023 01:53:31 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 6A43B240002; Mon, 24 Jul 2023 05:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690178001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lhg1DgAXkiZABvUkoHXZrowFOkMxepFe7NaWndb4mzQ=; b=ZGAHLPsJRksymYRpAEYC562xyqIQwA0fzDXG/RKuZEOeKhwiWz12RRCXH1HgBMfDxzvz42 qV88EIhh4YlYoq47GeujQabdk03ai31A+9vQx93GUC1NsgHys8Zz/4PEllNWjDkEZU2Wua /MYnuW1v3LVB5JYqhs/wob5rHaqUkcw+Tsmx9NKPNEERCo9qy09eFsNGtQ6i7CQp4ktHpx YgG2gJRTME8Zf/3jlv/ZCD4DdWGhyV2zrGjcqXaMK5XUlfT6gVhNuHxoVhhi5SA9OQu7Cz Zhc4i7DYrYrGOS1vvDF7LyS85Z4JIpXNIdc9WfTGSOWguX/Rk8+dNrNUViFn+A== In-Reply-To: <87sf9ehgoi.fsf@posteo.net> X-GND-Sasl: public@protesilaos.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266048 > From: Philip Kaludercic > Date: Sun, 23 Jul 2023 13:59:41 +0000 > [... 14 lines elided] >>> Does this even need a separate face, or shouldn't `help-key-binding' be >>> reused directly? >> >> That would be my choice, though also with the removal of the square >> brackets around it. The proposed patch is for backward-compatibility. > > Backwards-compatible to what? Just so that existing users do not complain. > Can someone depend on this specific behaviour? No, but the appearance still comes with certain expectations. Plus, there is this at the top of the file: ;; This is a GNU ELPA :core package. Avoid using functionality that ;; not compatible with the version of Emacs recorded above The required Emacs version is 26.1, while that of 'help-key-binding' is 28.1. Perhaps a user option for the whole 'format' would be better? -- Protesilaos Stavrou https://protesilaos.com