From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file Date: Wed, 08 Nov 2023 09:40:05 +0100 Message-ID: <874jhweize.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66982@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 08 09:40:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0e74-0008t0-2R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Nov 2023 09:40:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0e6t-0000sf-Uy; Wed, 08 Nov 2023 03:40:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0e6r-0000sX-O7 for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:40:26 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0e6p-0005Sp-RN for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:40:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0e7R-0001mw-US for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2023 03:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2023 08:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66982 X-GNU-PR-Package: emacs Original-Received: via spool by 66982-submit@debbugs.gnu.org id=B66982.16994328536851 (code B ref 66982); Wed, 08 Nov 2023 08:41:01 +0000 Original-Received: (at 66982) by debbugs.gnu.org; 8 Nov 2023 08:40:53 +0000 Original-Received: from localhost ([127.0.0.1]:43961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0e7J-0001mR-Am for submit@debbugs.gnu.org; Wed, 08 Nov 2023 03:40:53 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:52133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0e7H-0001mA-OR for 66982@debbugs.gnu.org; Wed, 08 Nov 2023 03:40:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1699432806; x=1700037606; i=michael.albinus@gmx.de; bh=8PfB82dieLtzcwJWhHUNtBPzlSnNcmoh18UOvt28IdU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=UCXQBY17C2fpBvXd+zbg3xerZ/U+UE5F8I2/n0PgZesDuXPDjjIZHCmINK3lgqgh JO2Fh513KkG21RkQSDND653pGG7KiRcenvpF4wReBya1um57XMoT2Jf2aaXplytC2 7iqcoPaCJ9CgyHiNNziP022cUuMaiDKUr4N8EI3iD+HBZ/4ZWgXqTpPUWjfn/nxr3 ie99AnvHD/jSyVR73jCgWdt6a86i+ziRBQIEuUTvnXr2eRhzkd0PITQYYtrcDMi1T e+aBnAvuanf3Kn906BlLnWcJ9On3stTkts1aCVzhg7Trv7ODi5nMrQzMqkakW1pbh KDPzynqCXkS3gh/0Rw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.30]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MzQkE-1rMjMk2ccK-00vL2v; Wed, 08 Nov 2023 09:40:06 +0100 In-Reply-To: (Liu Hui's message of "Tue, 7 Nov 2023 18:18:57 +0800") X-Provags-ID: V03:K1:HEpFf2eHTiSNBGhmS7WMqv4YMJGfEdpCY0hUGh1HJgFV0R8TZkw KOrX2tHncPZAX2Y6l2nxTCgN9IPi3Yu4sMuTFeTkmrdSSDLnYE+KN9maTEx3Jy8OOolLnY1 c/4UruPPdJn0LOrzbrm61VRF/arQWvnkI+6vq4V9v8sjT8rKWn4q2LRgNwCOYamOJnQBIhy Yf6TKybXKy7DjaS4TE0Sw== UI-OutboundReport: notjunk:1;M01:P0:ejapY6mMGeE=;kgtdi0YN/jFnAPuuSj6Fo+I4JVE bqoaf9F93e6PhGoqY9m/rr6xqRiuFwQvgC7kF9oZCbyHn8pRCXy2D/DVPv1BA6o9khAsrwueF rIvnKaD6b1NM+XuoHReOwftHME/+YEvppXAOBAl5WWyOXDgxeNZ+YtZUO0o/h6IYHL81RsYt6 liQeHDeev0e3a1EFFYmIiPJe7Kt5C/8AXUECV3RZ9s+F9BQrpQrjAWA1OIhX5RLDOT2lpaIRP X2AycIEuKIPp6hm3Uf5ersIRtTIShwd8pVlkrIO616KErSlPyK+ecW2Oo6nV4EH9/BpFPm+KJ hVWMNKDnCzA49TCpskpWo0iunagt07onniG8tGk9cGCVdjneoBhDUEI5Vgw72fI3bskz0y6xt Cutx55Cv9biMrpCUaZfAzS4WILHdqPU3Y5GbHxf+z7ECwh+msnLcJIWgtGSYLbLf3JWufX6Cu AAOJZ2aNkfd7ibtt6zkGNrRUxJFhIWJ5zUndfbDyGfaS78D10Lxm37fJLjTUQA1Fyt7DdAbQr MSLyUCjHKqBCLf9LuH0UQWNZp5F18Fed9ydF4OSv+Qbsuyo8kxGCePQxZGiy2npU1WBByUXRm L4bGH9Aa5hTZ6o4gkFu+9WvczH/cycveW5s4CNPxBrjzcuqOiJ3rXSyWs/rssPltPol3fteQy ypNrYLovFg+xUahrj6bOBHD0x4OpT9Utg8fguleRKLEoFxJOnMU/p+rO9Hshp+tmbMKDNiw71 B0/OZC6NYozHubKjnQSH/i+9EwahYrJLgoBOIaYUTv6V9LpbwfMcRjAvnPxtyRFIVHhhnE9B X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273973 Archived-At: --=-=-= Content-Type: text/plain Liu Hui writes: Hi, > Recipe: > > 1. Save the following text as the test bookmark file > > ;;;; Emacs Bookmark Format Version 1;;;; -*- coding: utf-8-emacs; > mode: lisp-data -*- > ;;; This format is meant to be slightly human-readable; > ;;; nevertheless, you probably don't want to edit it. > ;;; -*- End Of Bookmark File Format Version Stamp -*- > (("test" (filename . "/ssh:192.168.0.100:~/") (front-context-string) > (rear-context-string . "g-style=literal\n") (position . 68) > (last-modified 25595 64776 373828 978000))) > > 2. emacs -Q --eval '(setq bookmark-default-file xxx)' -f list-bookmarks > > 3. press d, then x. > > However, the bookmark cannot be deleted because Emacs hangs or displays > tramp error message/popup window after several seconds. Thank you for the recipe, I can reproduce the problem. It happens, because in `bookmark--remove-fringe-mark' there is a call of `expand-file-name', which blocks if a remote file is not reachable. Could you pls check the appended patch? It fixes your recipe for me, and shouldn't harm other use cases. Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 10ff2f5ebbf..71d76cb4291 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -511,6 +511,8 @@ bookmark--remove-fringe-mark See user option `bookmark-fringe-mark'." (let ((filename (cdr (assq 'filename bm))) (pos (cdr (assq 'position bm))) + ;; Don't expand file names for non-existing remote connections. + (non-essential t) overlays found temp) (when (and pos filename) (setq filename (expand-file-name filename)) --=-=-=--