* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
@ 2024-02-13 9:54 Philip Kaludercic
2024-05-03 7:36 ` Philip Kaludercic
0 siblings, 1 reply; 7+ messages in thread
From: Philip Kaludercic @ 2024-02-13 9:54 UTC (permalink / raw)
To: 69096
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
Apparently we forgot to set this option back when it was added, but it
makes sense to have it along with 'vc-prepare-patches-separately'.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] ; * .dir-locals.el: Set 'vc-default-patch-addressee' --]
[-- Type: text/x-patch, Size: 1046 bytes --]
From a9be9adaf6ae0c30a62d98c1705cfb308cffd69f Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Tue, 13 Feb 2024 10:52:24 +0100
Subject: [PATCH] ; * .dir-locals.el: Set 'vc-default-patch-addressee'
---
.dir-locals.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.dir-locals.el b/.dir-locals.el
index 89fb76a55f3..58fc135e202 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -14,7 +14,8 @@
("/[ \t]*DEFVAR_[A-Z_ \t(]+\"\\([^\"]+\\)\"/\\1/"
"/[ \t]*DEFVAR_[A-Z_ \t(]+\"[^\"]+\",[ \t]\\([A-Za-z0-9_]+\\)/\\1/"))))
(etags-regen-ignores . ("test/manual/etags/"))
- (vc-prepare-patches-separately . nil)))
+ (vc-prepare-patches-separately . nil)
+ (vc-default-patch-addressee . "bug-gnu-emacs@gnu.org")))
(c-mode . ((c-file-style . "GNU")
(c-noise-macro-names . ("INLINE" "NO_INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED"
"UNINIT" "CALLBACK" "ALIGN_STACK" "ATTRIBUTE_MALLOC"
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-02-13 9:54 bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee' Philip Kaludercic
@ 2024-05-03 7:36 ` Philip Kaludercic
2024-05-04 11:44 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Philip Kaludercic @ 2024-05-03 7:36 UTC (permalink / raw)
To: 69096
Philip Kaludercic <philipk@posteo.net> writes:
> Apparently we forgot to set this option back when it was added, but it
> makes sense to have it along with 'vc-prepare-patches-separately'.
ping?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-05-03 7:36 ` Philip Kaludercic
@ 2024-05-04 11:44 ` Eli Zaretskii
2024-05-04 13:34 ` Dmitry Gutov
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2024-05-04 11:44 UTC (permalink / raw)
To: Philip Kaludercic, Dmitry Gutov; +Cc: 69096
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Fri, 03 May 2024 07:36:34 +0000
>
> Philip Kaludercic <philipk@posteo.net> writes:
>
> > Apparently we forgot to set this option back when it was added, but it
> > makes sense to have it along with 'vc-prepare-patches-separately'.
>
> ping?
Dmitry?
I'm okay with this, FWIW.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-05-04 11:44 ` Eli Zaretskii
@ 2024-05-04 13:34 ` Dmitry Gutov
2024-05-04 14:15 ` Philip Kaludercic
2024-05-19 22:48 ` Stefan Kangas
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Gutov @ 2024-05-04 13:34 UTC (permalink / raw)
To: Eli Zaretskii, Philip Kaludercic; +Cc: 69096
Hi Eli,
On 04/05/2024 14:44, Eli Zaretskii wrote:
>> From: Philip Kaludercic<philipk@posteo.net>
>> Date: Fri, 03 May 2024 07:36:34 +0000
>>
>> Philip Kaludercic<philipk@posteo.net> writes:
>>
>>> Apparently we forgot to set this option back when it was added, but it
>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>> ping?
> Dmitry?
>
> I'm okay with this, FWIW.
I didn't think this was my area, but the change also LGTM.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-05-04 13:34 ` Dmitry Gutov
@ 2024-05-04 14:15 ` Philip Kaludercic
2024-05-19 22:48 ` Stefan Kangas
1 sibling, 0 replies; 7+ messages in thread
From: Philip Kaludercic @ 2024-05-04 14:15 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Eli Zaretskii, 69096
Dmitry Gutov <dmitry@gutov.dev> writes:
> Hi Eli,
>
> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>> From: Philip Kaludercic<philipk@posteo.net>
>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>
>>> Philip Kaludercic<philipk@posteo.net> writes:
>>>
>>>> Apparently we forgot to set this option back when it was added, but it
>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>> ping?
>> Dmitry?
>> I'm okay with this, FWIW.
>
> I didn't think this was my area, but the change also LGTM.
Yes, I worked on vc-prepare-patch and related functionality for the most
part, hence the suggestion.
--
Philip Kaludercic on peregrine
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-05-04 13:34 ` Dmitry Gutov
2024-05-04 14:15 ` Philip Kaludercic
@ 2024-05-19 22:48 ` Stefan Kangas
2024-05-20 6:35 ` Philip Kaludercic
1 sibling, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2024-05-19 22:48 UTC (permalink / raw)
To: Dmitry Gutov, Eli Zaretskii, Philip Kaludercic; +Cc: 69096
Dmitry Gutov <dmitry@gutov.dev> writes:
> Hi Eli,
>
> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>> From: Philip Kaludercic<philipk@posteo.net>
>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>
>>> Philip Kaludercic<philipk@posteo.net> writes:
>>>
>>>> Apparently we forgot to set this option back when it was added, but it
>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>> ping?
>> Dmitry?
>>
>> I'm okay with this, FWIW.
>
> I didn't think this was my area, but the change also LGTM.
Philip, did you push this already?
If no, please go ahead, if yes, don't forget to close the bug. ;-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee'
2024-05-19 22:48 ` Stefan Kangas
@ 2024-05-20 6:35 ` Philip Kaludercic
0 siblings, 0 replies; 7+ messages in thread
From: Philip Kaludercic @ 2024-05-20 6:35 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Dmitry Gutov, Eli Zaretskii, 69096-done
Stefan Kangas <stefankangas@gmail.com> writes:
> Dmitry Gutov <dmitry@gutov.dev> writes:
>
>> Hi Eli,
>>
>> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>>> From: Philip Kaludercic<philipk@posteo.net>
>>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>>
>>>> Philip Kaludercic<philipk@posteo.net> writes:
>>>>
>>>>> Apparently we forgot to set this option back when it was added, but it
>>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>>> ping?
>>> Dmitry?
>>>
>>> I'm okay with this, FWIW.
>>
>> I didn't think this was my area, but the change also LGTM.
>
> Philip, did you push this already?
No I haven't yet, but I will right after this message.
> If no, please go ahead, if yes, don't forget to close the bug. ;-)
Thanks, I was just wanting for another ACK.
--
Philip Kaludercic on peregrine
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-05-20 6:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 9:54 bug#69096: [PATCH] Set default value for 'vc-default-patch-addressee' Philip Kaludercic
2024-05-03 7:36 ` Philip Kaludercic
2024-05-04 11:44 ` Eli Zaretskii
2024-05-04 13:34 ` Dmitry Gutov
2024-05-04 14:15 ` Philip Kaludercic
2024-05-19 22:48 ` Stefan Kangas
2024-05-20 6:35 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).