From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nate Sandy Newsgroups: gmane.emacs.bugs Subject: bug#69782: [PATCH] Fringe bitmaps should respect alpha-background Date: Tue, 19 Mar 2024 13:01:21 +0000 Message-ID: <874jd28jfi.fsf@posteo.de> References: <87edcex7vl.fsf@posteo.de> <87o7bbr632.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5550"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69782@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 19 14:34:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmZc8-0001GA-8I for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Mar 2024 14:34:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmZbn-0004t1-TN; Tue, 19 Mar 2024 09:34:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmZbj-0004pk-T3 for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2024 09:34:24 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmZbj-0001mc-Ki for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2024 09:34:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rmZcM-0000SK-3T for bug-gnu-emacs@gnu.org; Tue, 19 Mar 2024 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nate Sandy Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Mar 2024 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69782-submit@debbugs.gnu.org id=B69782.17108552991723 (code B ref 69782); Tue, 19 Mar 2024 13:35:02 +0000 Original-Received: (at 69782) by debbugs.gnu.org; 19 Mar 2024 13:34:59 +0000 Original-Received: from localhost ([127.0.0.1]:49464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rmZcH-0000Rb-KR for submit@debbugs.gnu.org; Tue, 19 Mar 2024 09:34:58 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:41693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rmZ6a-0006LY-3p for 69782@debbugs.gnu.org; Tue, 19 Mar 2024 09:02:13 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 16377240101 for <69782@debbugs.gnu.org>; Tue, 19 Mar 2024 14:01:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1710853287; bh=qiU0E3eQ1NO/vO0Fz1ikHF2kvz/svR0D2eRsKCGRkUs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=b8HADstz3XhcBBdLbR+2NWt+JPNJ4KuZV89+eQmwcvbDLCTEPoeLzTahhwteZsJln 9rntBNObiCDJVAk1r3+/sJOTJSQGKihYQSN7w3ck/yUYCY8GUVJ84xvB/GqaPB3G3x DOUXEL/Jjf4rbm4hg0D6R8J1lk23s8A8yD0c0AS17n6hAzs7ku254LgvJusyOnzy4o 1opBq1IUNaYVoG/CF3u24KoFget1E5zYd3QEAQxL005g7Pf+5o5agTzb5YOyutPNSh fptGHGGY/GurHrWeE71Wz/G19yIm2/uo4zf6oL+LpVp/ufU4ekKn5FMRIJ23cbTHcR oSY2mXrZuzEYg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TzX0k3fPvz6tvd; Tue, 19 Mar 2024 14:01:26 +0100 (CET) In-Reply-To: <87o7bbr632.fsf@yahoo.com> X-Mailman-Approved-At: Tue, 19 Mar 2024 09:34:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281831 Archived-At: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > PGTK and GTK 3 or no-toolkit X builds, with either Cairo or XRender. Thanks, I will test with those in the next iteration of this patch and add a ChangeLog entry. >> The change is altering the parameter 'respect_alpha_background' in >> {pgtk,x}_cr_draw_image - while this name sounds quite generic, I didn't >> find any other usages of this function than drawing fringe bitmaps. I >> hope I didn't miss any. > > What about x_draw_image_foreground? Right. That in turn only gets called by {pgtk,x}_draw_image_glyph_string. I was unable to determine what those image glyphs are and how to create one, in order to observe whether this patch would be detrimental to them. However it does seem sensible for backgrounds to respect alpha-background here as well. Where do these image glyphs get used? I didn't notice any difference with the images I tested (having applied this patch).