From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70791: 30.0.50; edebug-remove-instrumentation doesn't see instrumented functions Date: Mon, 06 May 2024 21:07:52 +0200 Message-ID: <874jbarc6v.fsf@web.de> References: <871q6ghy3k.fsf@gmail.com> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40738"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: agzam.ibragimov@gmail.com, monnier@iro.umontreal.ca To: 70791@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 06 21:08:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s43h8-000AQs-Tu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 May 2024 21:08:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s43gl-0003v6-3G; Mon, 06 May 2024 15:07:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s43gY-0003ic-BK for bug-gnu-emacs@gnu.org; Mon, 06 May 2024 15:07:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s43gY-0000ls-21 for bug-gnu-emacs@gnu.org; Mon, 06 May 2024 15:07:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s43gw-00067j-61 for bug-gnu-emacs@gnu.org; Mon, 06 May 2024 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 May 2024 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70791 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Ag Ibragimov , Stefan Monnier , 70791@debbugs.gnu.org Original-Received: via spool by 70791-submit@debbugs.gnu.org id=B70791.171502247023528 (code B ref 70791); Mon, 06 May 2024 19:08:02 +0000 Original-Received: (at 70791) by debbugs.gnu.org; 6 May 2024 19:07:50 +0000 Original-Received: from localhost ([127.0.0.1]:39729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s43gk-00067Q-9a for submit@debbugs.gnu.org; Mon, 06 May 2024 15:07:50 -0400 Original-Received: from mout.web.de ([212.227.15.4]:51893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s43gf-00067B-C3 for 70791@debbugs.gnu.org; Mon, 06 May 2024 15:07:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1715022430; x=1715627230; i=michael_heerdegen@web.de; bh=1X5QIXNOFccfqCynecCLO03OpIs45BS0+ZEdmmrKEn0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=UXTu1cjXlfrJAaIxI3pzZYCcVj45zwMs0LBM2HMYoJ+WxBAMcDs1WrizkpGJIKeH c3s3pkKtm1WUU2/+7NST9Tok2Ec8RFBTRHtZ37WhEZGTvaAyxhkJyntH0x8ughDlz T5EFUcEdT7ZUgmD7J1etlubgBqp3o+FVxvBLG4MOvzebTgprrugFWIs1llkpCnk9/ 3mdzvJrdiJiLgTRPPup9FI96mDxDwUFSXWD4wv34DPtDVAVGyIo31U8SChja4sZTK KnMhGHPB7F1G86kst3Glsx/1idKWPvmMnXgGgmdjfPGoP63PqqeMZAv7z09b+3fuo HLoxQAYeA48obUGlkw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.57.248.23]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MAtwr-1rsk592JKL-008P1L; Mon, 06 May 2024 21:07:10 +0200 In-Reply-To: (Stefan Monnier via's message of "Mon, 06 May 2024 14:38:48 -0400") X-Provags-ID: V03:K1:wmzPxjoKm58D39BNWwVCn0Gx5LFVTEHpg9fkC4S8Ppg+4YIp+V/ TAzksHGszl9LdBFvxNMCtSNQ+nG08y2k+m3peUaiud4ejkFeAqmt8oAfAhthVaROkzN+cuP /7+3gZ2/tRhPFRdltjLeseWqeY163cfg59ltAaaQXFQ6mFuoJC90w1ATbGCSH61PC5PLpd1 fw4gE53cQE6INRkiRMoMQ== UI-OutboundReport: notjunk:1;M01:P0:x1wDKPN0TF8=;2+jAT//QH4FMZPjP6GOlvXK3Lo8 gUxuJQh2Eh3pmchy8W4iyCGs//Pdqe6zDMcO+IQqYMh1wHs3bPhUPy1lsYo7UkrUPupmQHQ/8 QlNioWcvOpmwZuUF0s9VN4arDM6EicIxJI3flG52nidPq/VpvyqBQFpZSuxvzlNPWnlaaFaAP US4XTpJEf12PJpY60b+m3CETqoTFZX10/96iy0Zq3QkuLHIl8eSf3mBobiwStJVWcsECH+CxT nNVoJuQ472iy0hp4fP6hP53wWK/37mw3qWGK/Z/2sW5Ev/JfIvLeGry5PHGO+un/QjZ4Yt22r Bl8wW1tmBScFBVEWjQODhcRNfMlcU6bdwpaHm84PE4jTTFVtp6sHAlMoYPDKXX2N9QuGWsYdv A7aaKlmxucFTP5g3YDrsr/vQ84Ag4Jc1gjDNS5OASw1zRkTpdRQ3HbajTS8NhDUZZPtewD9G3 KB5HTIjO9VCeDI4grAXJMInQLYd+4cXqZu9zRma4zmL/oNVU0Fqsm3OqfLCnUEMcKwQ2hg7kp aafKrmNUW/BiQrow5Wn2ZvXBYGMv4W+62V7DUkzG+G1Awz5P867AnW8thyxmzh2uymypAgDzk p70UKe+7FFMfvHbUG6AaAF4iWvSvCvDOCI30w+0Luyitq4W1WPvMlx0Ha0OIv2Shpgmox2MBf QpTfTwNOeE+9X1PzM+a2Tbrv+5AAkwHG88wKlSttxP36XFqcul5sPFYijh2wxaqSS6O1D79AO P9cBNI1L1xNT/NmH4/bEk2iIfc6uw6+0a4lMo+0kzLt8m+Qi22xD/MW3F5peEK9w6A/IT6ag X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284607 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > I noticed that after instrumenting a function > > (edebug-remove-instrumentation) doesn't let you uninstrument it, > > showing: > > I believe it should be fixed now on `master`. Thanks. Works for me. Did not test extensively but simple examples work again. > Side note: as it is currently implemented, > `edebug-remove-instrumentation` cannot work reliably (and the way it > discovers the set of functions that can be un-instrumented is quite > wasteful, tho it seems it does the job), so I recommend you `C-M-x` to > redefine the function instead. One important use case is the ability to deinstrument all functions at once in a convenient way, so I think we at least want to keep some kind of deinstrumenting function. Thanks, Michael.