From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69941: 30.0.50; Faulty fontification of radio button widgets Date: Sat, 25 May 2024 11:30:23 +0200 Message-ID: <874jam9r2o.fsf@gmx.net> References: <87h6gynx49.fsf@rub.de> <87o79c8n60.fsf@gmx.net> <87zfst4zuh.fsf@rub.de> <87v83h4y31.fsf@rub.de> <86zfsez5w3.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69941@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 11:31:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAnk6-0004iP-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 11:31:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAnjt-0004dQ-V6; Sat, 25 May 2024 05:30:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAnjr-0004Z1-VK for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:30:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAnjr-0003qU-5w for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:30:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAnjy-000544-Hc for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 05:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69941 X-GNU-PR-Package: emacs Original-Received: via spool by 69941-submit@debbugs.gnu.org id=B69941.171662945519462 (code B ref 69941); Sat, 25 May 2024 09:31:02 +0000 Original-Received: (at 69941) by debbugs.gnu.org; 25 May 2024 09:30:55 +0000 Original-Received: from localhost ([127.0.0.1]:42350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAnjq-00053q-GY for submit@debbugs.gnu.org; Sat, 25 May 2024 05:30:54 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:55439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAnje-00053i-9j for 69941@debbugs.gnu.org; Sat, 25 May 2024 05:30:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1716629424; x=1717234224; i=stephen.berman@gmx.net; bh=IQ/maz2/ThbfPetmgMClxRHEO0rNKMohlJicwMN7920=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=KjzHYh20lUCQlkhvhEJj7u6PIG1o1jo5AgWRV2puG7AUmncosVoAxZf5G/0Otcy+ oJCiD0ae/4YIVV04w5Wj1cCndBDOsEHdGgdBS+CUTtBEaowr+13KCX1nGX2ayig9t Acs0hH1qEJGx7CZdoVil2V0c5COaxrYxNaDG0LkT1aQueLDOCx7c5A/ywTd+zYw/2 3K2ZkhC4uVtySSL45h98Wew9QAf0YmVHd+0UTfagEX/vJqgFDgrlBGn2jiRpRv7jR Rr/m2iTAleaz65QVX7Pz7c9fuleJqI/UnYM/7/P2bOBp2e6DIfCzZYtjKLbEpvAJX T736aN/2M3OaHa5J2g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.95.181]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTiPv-1s52yr2tuH-00U65s; Sat, 25 May 2024 11:30:24 +0200 In-Reply-To: <86zfsez5w3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 May 2024 10:51:08 +0300") X-Provags-ID: V03:K1:cHE76IHJ7dbHUY2Q4NNuRRVnVF9aBOES0JISANOgNu3V5qEc/Fw NWTivRh05idFVz8eYsKHO47mIImkKgDWApv6v80esnGVmfFZuqzBt5XlRRWX79Umk4k2bJy /DBhpAavK5C1K9g1/iRE9/y8WeFJ78SyiF1UH0k+8pmeQ1ohs4jYNN2iCvBiKXFJMbNwd0T 5LoosUP2nB0xK1GDFLffw== UI-OutboundReport: notjunk:1;M01:P0:VFYEnUzGWUU=;MTAYb1zJWwbJeZqU11Q9Ytbtgn4 3f+1+ZKPUJh2uizzWdg/JG6Rk4CbOVbhrFjHuYZRQC3FHUYUuaB1radOPKEWJxxqCwPk2e+ZY J3gr0ICiqW9xB/xZh1bOQ2+m3iA3bRphq9LoANuggutTiXrEbb042ARzuiyIToRTXClRbsGlT yt1PyL6suN5D/QkKr08bJg1JAGy7g6h5rId/YHx0e85acmyWnAkeDu8hVJg5UcX+YHLd10/kn vK/tKyEEWYMA7pPvQjz+x2vvrMdmsBBwxs8+eZvImb0AUtXpqeh8lRUINJBVPDkEDS16b70Gm caHRipF5grlzcNKf/IQaP0R7KDffz+VMCozqoTyItShe1NAsEuyEoF9CwSdQIpsCSg/R+ifjb ex7rE0wJClFTQk8cU4PbatzCJVy0lWzqLJonlXvR+g/murT0qxurQDQ7NCFzj8n+cKgFXuxVK I5Y+3PompvVTp0xuvqG8hQwWeTze0JQF6Np1NWlrU8J5C9K3CM1O5lUhNpaiY9192u5qcSRXP CsGcv8tWzpEjsvshkAfxOYE7YeFSRk7L2T0pbpxZiGf5MD8E7Nv3Fyu+Nrv2FFDlsXDDNVr5V 8K4bnq5Ns4U0N8RKBf0RbWnkfACIXWpIPGl4JAa6GFQoflul3RzJkheu18Cg7ICHEFHD4qgIj eKajlyzlwuyvHHDBvSEgI/I2YWfIpA+P/IOvsy2MbT9pH7yatYjEVEnjj4/3rRTokSoi5TV/2 wlDoAdnziVAMvzqebPKQYq15KNRxzV0bY1Zg/wxR1LBdL/9N2gTheum5Hif0CLyGrUi/k4qb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285847 Archived-At: On Sat, 25 May 2024 10:51:08 +0300 Eli Zaretskii wrote: > Ping! Any further comments about this, or changes to install? I haven't been able to pursue Stefan's suggestions yet. For the use case for which I made the patch, I find the results overall better than without it. Nevertheless, text inserted in front of the first radio button unintentionally getting fontified with widget-inactive face is a clear bug, so I think the patch should not be installed; I hope I (or someone else) can improve it. Steve Berman >> Cc: 69941@debbugs.gnu.org >> Date: Mon, 13 May 2024 10:19:43 -0400 >> From: Stefan Monnier via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> Or maybe `widget-*-add-item` should temporarily change the insertion >> >> type of the from/to markers? >> > What do you mean by "temporarily"? >> >> I think you underestimated the meaning of: >> >> I'm really not familiar with the widget code >> >> I put "really" before the "not", because I know very little about >> that code. >> >> > Maybe it could be left up to the deactivation code to ensure that the >> > radio-button-choice widget's :from and the :from of its first child >> > coincide when deactivation (and accompanying fontification) occurs, a= nd >> > then reset the previous values afterwards. >> >> I suspect thinking in terms of "activation/deactivation" will not >> be helpful. We should look at the code which does the insertion of tex= t >> (which presumably happens, among other things, upon deactivation). >> >> > Though that seems pretty ad hoc... >> >> If needed, we might be able to make it less ad-hoc by defining >> a function for the purpose of (re)inserting text inside an >> existing widget. >> >> > (and would resetting the :from affect the fontification?) >> >> It'd be up to that new function to make sure things work as they should= . >> >> >> Stefan >> >> >> >> >>