From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73734: [PATCH] Fix tmm menu layout Date: Fri, 11 Oct 2024 08:37:00 +0200 Message-ID: <874j5j87sj.fsf@ledu-giraud.fr> References: <87cyk812uv.fsf@ledu-giraud.fr> <86iku00wbz.fsf@gnu.org> <878quv96sk.fsf@ledu-giraud.fr> <868quv24mb.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rudalics@gmx.at, 73734@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 11 08:38:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sz9I0-000A4c-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Oct 2024 08:38:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sz9Hl-000583-Si; Fri, 11 Oct 2024 02:38:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz9Ha-000577-0H for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:37:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sz9HZ-0000BN-Oa for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:37:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2t3U5sI320suIqjq5GcI4sRVIBCyA7hoLbWs1DjANRA=; b=NnC6hBYYDrcXVeJWJVfUCRp+EIqfbvZ2asN1ntyCghdQjLIqIq/EUXozEnaJZ//u0uUZnpbaEY7haeEFhWIZ9jfIcEpfq/4W/C/y90j998srrLceW+9tC5tzRp7WfTFLqNBZOT2xopi1G2dCLiUbQ/875j/nS80HBWj9lFa/qp+gP8gMKwzvdxkSuTyegzfkGicNMYFnLvEkj1UrQF+G5trGia7VqQvuFMWeeIfVmyV6Yc+Lbf9h/MrVjmlz6HtsH63TDIgg6kxTTjfWJzpGVN1Y7C6co7ftikVsinzsfTsmDLH+bKJF7KYFZHgasaLSvGTpiWtut57125VQLyASMA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sz9Hm-0005jK-0o for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2024 06:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73734-submit@debbugs.gnu.org id=B73734.172862864121966 (code B ref 73734); Fri, 11 Oct 2024 06:38:01 +0000 Original-Received: (at 73734) by debbugs.gnu.org; 11 Oct 2024 06:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:33210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz9H7-0005iE-AN for submit@debbugs.gnu.org; Fri, 11 Oct 2024 02:37:21 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:24367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz9H4-0005i4-Ec for 73734@debbugs.gnu.org; Fri, 11 Oct 2024 02:37:19 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=OQ2M0e6M 5oItQiOC3ntzPxQIFjeVUdUY7gGoaHtA68A=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Uclty1fxwI5JE5vbLMondcQ+DpgE5/ TZEdn777X6hgd9T0+UV/BBURTTyUVCa0MEPLLIEb6mo43q6q8Q5CFJDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=OQ2M0e6M5oItQiOC 3ntzPxQIFjeVUdUY7gGoaHtA68A=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=YBeve4dsuIWZ/PoxeTwczojMSV4A4nkCtK0OYV Lo/qrQbXp9dV9uHP2cmrTgxsC/zav97JViXCTcleIQIZQupLc+mHmDz2y+UGmqcfQxfYtm DAi5P3xXw8kiDPJUPS56TDRaQSnj7RwItpvcKCyrfr+77Jmg54kBphieiRCJzSVxOQtNkL HTxg9Bm7fd6Ju0xiC4i11BnDrotcYVjPH8r2Vt/FJ7qjCtVjW4Ckp0Y09yZBb+cP+LwCSm STBgKFpwVcTa3qcidiR9vkwg+U/GBVugROisi88XqdUtA9GkhiMfYfeuOATk+1pxRgpAGX ItY5QVJ/bW6mZ3rR3Eg8aaxw== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 22715568 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 11 Oct 2024 08:37:02 +0200 (CEST) In-Reply-To: <868quv24mb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Oct 2024 21:29:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293336 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: martin rudalics , 73734@debbugs.gnu.org >> Date: Thu, 10 Oct 2024 20:00:59 +0200 >> >> > What is the "selection character" in this image? >> >> On the image below, "n" is what I called the selection character for >> "Next Marked" while "* c" is the keybinding for "Change Marks...". The >> proximity of those two makes this hard to read IMO. > > Ah, I see now what you meant. But if this is the problem, then > changing the column width is not a reliable solution, because you > cannot know in advance what will be the width of the SPC glyph in a > font people use. I suggest to use 'display' properties instead, for > example '(space . (:width N)), where N is the number of canonical > columns we want the space to take on display. Sure this will be more reliable for proportional font's users but we'll still need to calculate this N that would be (- colwidth (string-width str) (string-width binding)) I think. And so we still need a value for colwidth, no? [...] >> >> Here, how I justify the modification of `colwidth': >> >> >> >> - I don't think we need the "(min 30)" part since, if the frame is >> >> wide enough, we always get a colwidth of 30. >> >> >> >> - I don't think "(window-width)" is what we need since, by >> >> default, the *Completions* buffer will use the full frame width. >> > >> > Martin, is that guaranteed? >> > >> > And even if it is, what's the harm in keeping window-width? >> >> I don't think that a full frame width *Completions* buffer is >> guaranteed: it is only what I see with "emacs -Q". >> >> Keeping window-width in this calculation seems a bit strange because, by >> default, it has nothing to do with the *Completions* buffer window >> width. > > Which window's width does this return in this case? AFAIU, this window-width call is done from the user's current window. -- Manuel Giraud