From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rudalics@gmx.at, 73734@debbugs.gnu.org
Subject: bug#73734: [PATCH] Fix tmm menu layout
Date: Fri, 11 Oct 2024 08:37:00 +0200 [thread overview]
Message-ID: <874j5j87sj.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <868quv24mb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Oct 2024 21:29:48 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: martin rudalics <rudalics@gmx.at>, 73734@debbugs.gnu.org
>> Date: Thu, 10 Oct 2024 20:00:59 +0200
>>
>> > What is the "selection character" in this image?
>>
>> On the image below, "n" is what I called the selection character for
>> "Next Marked" while "* c" is the keybinding for "Change Marks...". The
>> proximity of those two makes this hard to read IMO.
>
> Ah, I see now what you meant. But if this is the problem, then
> changing the column width is not a reliable solution, because you
> cannot know in advance what will be the width of the SPC glyph in a
> font people use. I suggest to use 'display' properties instead, for
> example '(space . (:width N)), where N is the number of canonical
> columns we want the space to take on display.
Sure this will be more reliable for proportional font's users but we'll
still need to calculate this N that would be (- colwidth (string-width
str) (string-width binding)) I think. And so we still need a value for
colwidth, no?
[...]
>> >> Here, how I justify the modification of `colwidth':
>> >>
>> >> - I don't think we need the "(min 30)" part since, if the frame is
>> >> wide enough, we always get a colwidth of 30.
>> >>
>> >> - I don't think "(window-width)" is what we need since, by
>> >> default, the *Completions* buffer will use the full frame width.
>> >
>> > Martin, is that guaranteed?
>> >
>> > And even if it is, what's the harm in keeping window-width?
>>
>> I don't think that a full frame width *Completions* buffer is
>> guaranteed: it is only what I see with "emacs -Q".
>>
>> Keeping window-width in this calculation seems a bit strange because, by
>> default, it has nothing to do with the *Completions* buffer window
>> width.
>
> Which window's width does this return in this case?
AFAIU, this window-width call is done from the user's current window.
--
Manuel Giraud
next prev parent reply other threads:[~2024-10-11 6:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:53 bug#73734: [PATCH] Fix tmm menu layout Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 16:14 ` Eli Zaretskii
2024-10-10 18:00 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 18:29 ` Eli Zaretskii
2024-10-11 6:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-11 6:51 ` Eli Zaretskii
2024-10-11 7:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:26 ` Eli Zaretskii
2024-10-11 10:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 16:44 ` Eli Zaretskii
2024-10-12 14:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 14:44 ` Eli Zaretskii
2024-10-12 15:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 16:26 ` Eli Zaretskii
2024-10-12 16:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 8:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 9:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:15 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j5j87sj.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=73734@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).