From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git) Date: Sun, 12 Nov 2023 22:37:42 +0200 Message-ID: <8742d731-62ba-0808-bdc6-cbad1cf98116@gutov.dev> References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@gmail.com> <83y1f4wxby.fsf@gnu.org> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@gutov.dev> <83sf5bv77j.fsf@gnu.org> <83bkbzusri.fsf@gnu.org> <86msvi95aw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17239"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: jporterbugs@gmail.com, Eli Zaretskii , 67062@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 12 21:38:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2HE2-0004DU-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Nov 2023 21:38:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2HDq-0002VJ-JU; Sun, 12 Nov 2023 15:38:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2HDp-0002UZ-0v for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:38:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2HDo-00048B-Nm for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:38:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2HET-0000oq-QH for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 15:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2023 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67062-submit@debbugs.gnu.org id=B67062.16998215153117 (code B ref 67062); Sun, 12 Nov 2023 20:39:01 +0000 Original-Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 20:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:57096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2HE2-0000oC-O9 for submit@debbugs.gnu.org; Sun, 12 Nov 2023 15:38:35 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:32981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2HE0-0000nw-6q for 67062@debbugs.gnu.org; Sun, 12 Nov 2023 15:38:32 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E8F925C036A; Sun, 12 Nov 2023 15:37:45 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 12 Nov 2023 15:37:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699821465; x=1699907865; bh=oymgGVnpNPVq+8T4VK0KObB5bC/vWGIwXsu 1TEXn5Yk=; b=l4BUC8969U43AaP0oKUYuWK4yyla1J18trz0D1wexfThJW0al6z SlxtTIRJ2lmxEnGQ0RqSlEGdO5Cc2DN+23/BHGuh5kMFVrBgKGFX9jCAAYH1Oysn QyRVmARWfHX7nmpjo6YMuSbRghyeFImqn3jMCZjjxun7Gu/7T3oWuOcbtdt/aIdI C4Yp+Yje7FkqTUp9TR8PDSGnP8nj51ICcpVAmWPx4IgYEaDbGS8G2RrvDTxomvEW I/vC9g67y2CAFdcZTRjouh/usXKEYRrA0GZ9ZUFrKRJ4dD4TsrL1VgbLIQwf4X/B aNWjqqOc3N7AuoDlLJSEod+6R5wpGWDNptA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699821465; x=1699907865; bh=oymgGVnpNPVq+8T4VK0KObB5bC/vWGIwXsu 1TEXn5Yk=; b=eSl2arbIlKtw1PNwr99xM6HrpzzwG/9TzKzvLvDDZ8y9VZ99nyS vOn+Hy2UHUQqtKI0PIl7zdb6C6BEnwW5rzc2+Uu4lYpXRqL9thbsbESxj5t9cBrB 3vDqCoqjZf58bTpc659hOhRkoNU42ho0gZPTwVpkZrytadIzEWEuXf+g/Bs+P7O/ +FTiNJUPGeRU5LQUFekUTOm/CNQg+mCY3it8mWNuI0xrBHdUUsSXJ4Cfz9BUt2XM pxYb1hIFtO0JVOqQN7mPhCBGRQRJ50Li6zIN9auG/Vferu69tYLoRm3sCPRV3TD0 2gPGpd5Jv7+0W4Y3b0eQR1YGzPDmjjiizMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Nov 2023 15:37:44 -0500 (EST) Content-Language: en-US In-Reply-To: <86msvi95aw.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274227 Archived-At: On 12/11/2023 20:48, Juri Linkov wrote: >>> no, vc-annotate will call a new function, which will have a special >>> code for Git alone. >> That's one extra indirection, but conceptually the same. We couldn't modify >> vc-working-revision for this, so it'll have to be a new function. > But maybe could add a new optional arg to vc-working-revision? That's worse: we'll end up with a number-of-args migration, having to use a condition-case form for a number of years. All for a new argument that isn't used by the majority of the backends.