From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58784: 28.2; project-buffers incorrect under let-bound default-directory Date: Fri, 4 Nov 2022 03:18:40 +0200 Message-ID: <873fe4fa-4139-671b-0990-18833a6947a5@yandex.ru> References: <0b56cc0a-b8d4-86dc-4b67-217387aeb1b2@yandex.ru> <938BB7EA-3902-4025-98B5-914D514B4A63@toadstyle.org> <208cd0a0-8244-9cac-ff16-9ef23b56ca9b@yandex.ru> <35907670-3546-45B8-8E3C-2C482B8E3464@toadstyle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13730"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: 58784-done@debbugs.gnu.org To: Sean Devlin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 04 02:44:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqll2-0003S6-Jk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Nov 2022 02:44:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqlko-0003HD-Ml; Thu, 03 Nov 2022 21:44:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqlMM-0002gS-Bl for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqlMM-0003x5-0z for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqlML-0005an-SF for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:19:01 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Nov 2022 01:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58784 X-GNU-PR-Package: emacs Mail-Followup-To: 58784@debbugs.gnu.org, dgutov@yandex.ru, spd@toadstyle.org Original-Received: via spool by 58784-done@debbugs.gnu.org id=D58784.166752473221476 (code D ref 58784); Fri, 04 Nov 2022 01:19:01 +0000 Original-Received: (at 58784-done) by debbugs.gnu.org; 4 Nov 2022 01:18:52 +0000 Original-Received: from localhost ([127.0.0.1]:51069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqlMB-0005aK-Vy for submit@debbugs.gnu.org; Thu, 03 Nov 2022 21:18:52 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:43565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqlM8-0005a5-GF for 58784-done@debbugs.gnu.org; Thu, 03 Nov 2022 21:18:50 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id g12so5059543wrs.10 for <58784-done@debbugs.gnu.org>; Thu, 03 Nov 2022 18:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=uXZl74W8rzLeBghfR0Lpqe+wPkEKCq2G376YLGCoNjk=; b=ZoSfKFZ2GbmNtE7660qIzFIphlBcIcu4+Xbdl2hZOa9TRmx+XZxlxyvjjOxvV8RRZ2 MEAcrqy8JG1zMW5O+NuNb207/Qzr91Qwor33hM/pqdKkR6JF3YsHKp3QjxbDuwk0/NgD skJ7AG5TLlrR2nvLbfxN9nRzCpaYmFRqtyDDEs5azQU8TqoWZEbRo+0PfQZBfwIlkAhm +PWC0DsfphbDOfKdeSmz8s0kYKm7fCgO4SwJ8YoNMheF0LE+02WEyTsECd0HWOqCjJWG XKnspr3YsyXNaNGOAWOgpWu+HE9i7ylOgNMP03ZFvolqVem48OA+tLFRhpigv9HlPMqg QboQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uXZl74W8rzLeBghfR0Lpqe+wPkEKCq2G376YLGCoNjk=; b=PEpbhSlYsdBIXaUvso2pOam3CiJrkYdMqSkP6mlZGxLbUuMJMBxreFpVeB9Nzhqogh XFgtutTmkwKTL3Tl960peSgTtuTA9b5kTW6HHx2L7i4jGNDqZYo3W+r9PRFMi0tcaFCg Wvpeyltj0Qm9qZ+hnMvF8o1e8TTwZmX4RlIBW0Xjhzz13Ie9yAxt3Qs2iT5s2rLjqkAy oagrRssaBWYJbjWwSB/PKI7fXROKbc7+QjJWGlZH9RENrn8pbDnaebZQV5xrQrKGTls4 AG134HMho4+VXOMBVOka98ms8A4jIlOpuo5Ls3huqauIpczjnn/ZuRwggFqWJvVzc5Wm Zx8w== X-Gm-Message-State: ACrzQf3m7xbLR4rlLsA8AWpCRZM6nHNyae4ixLEVIv9aUo4RBfkVV1Ak 6vMJuiFF5y2AjQlnVoWTz+w= X-Google-Smtp-Source: AMsMyM65fWchlO5vyFM/oZldhNIAF0GcUfrTJIIXKyR3nc06Bc2LXr4ksfZWWJD7weEexOCXhOOQuA== X-Received: by 2002:a05:6000:245:b0:236:a471:81c3 with SMTP id m5-20020a056000024500b00236a47181c3mr162496wrz.392.1667524722741; Thu, 03 Nov 2022 18:18:42 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p25-20020a05600c1d9900b003cf77e6091bsm1349949wms.11.2022.11.03.18.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 18:18:42 -0700 (PDT) Content-Language: en-US In-Reply-To: <35907670-3546-45B8-8E3C-2C482B8E3464@toadstyle.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247032 Archived-At: On 02.11.2022 17:18, Sean Devlin wrote: >>> I think there’s still some fragility in the project-buffers function, since any callers need to be careful not to bind default-directory. It might be useful to call this out in the doc string or in the manual. >> >> I suppose it could use improvement, but I'm not sure what phrasing would stop someone from making such a mistake. After all, I knew its implementation and made it anyway. >> >> Perhaps the docstring should simply say that the buffers are matched on the basis of their default-directory value. In the default implementation, that is (custom backends could choose their own strategy). Would that help? > > Yeah, I think a high-level description of the default strategy would be useful. > > Thanks again for your help! I've added some clarification in 7d47651d01. Hopefully it makes things better, if not -- suggestions welcome. I'm going to close this in the meantime.