From: Dmitry Gutov <dgutov@yandex.ru>
To: Sean Devlin <spd@toadstyle.org>
Cc: 58784-done@debbugs.gnu.org
Subject: bug#58784: 28.2; project-buffers incorrect under let-bound default-directory
Date: Fri, 4 Nov 2022 03:18:40 +0200 [thread overview]
Message-ID: <873fe4fa-4139-671b-0990-18833a6947a5@yandex.ru> (raw)
In-Reply-To: <35907670-3546-45B8-8E3C-2C482B8E3464@toadstyle.org>
On 02.11.2022 17:18, Sean Devlin wrote:
>>> I think there’s still some fragility in the project-buffers function, since any callers need to be careful not to bind default-directory. It might be useful to call this out in the doc string or in the manual.
>>
>> I suppose it could use improvement, but I'm not sure what phrasing would stop someone from making such a mistake. After all, I knew its implementation and made it anyway.
>>
>> Perhaps the docstring should simply say that the buffers are matched on the basis of their default-directory value. In the default implementation, that is (custom backends could choose their own strategy). Would that help?
>
> Yeah, I think a high-level description of the default strategy would be useful.
>
> Thanks again for your help!
I've added some clarification in 7d47651d01.
Hopefully it makes things better, if not -- suggestions welcome.
I'm going to close this in the meantime.
next prev parent reply other threads:[~2022-11-04 1:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 0:13 bug#58784: 28.2; project-buffers incorrect under let-bound default-directory Sean Devlin
2022-10-29 0:49 ` Dmitry Gutov
2022-10-31 17:47 ` Sean Devlin
2022-11-01 23:35 ` Dmitry Gutov
2022-11-02 15:18 ` Sean Devlin
2022-11-04 1:18 ` Dmitry Gutov [this message]
2022-11-04 16:39 ` Sean Devlin
2022-11-21 18:24 ` Juri Linkov
2022-11-23 3:48 ` Dmitry Gutov
2022-11-24 2:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873fe4fa-4139-671b-0990-18833a6947a5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58784-done@debbugs.gnu.org \
--cc=spd@toadstyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).