bug#1335: Arch-dependant data should not be installed in the app bundle

bug#1335: Arch-dependant data should not be installed in the app bundle

[Yavor Doganov]

Package: emacs,ns

I see no reason to install arch-dependent data in the app bundle when
--ns-disable-ns-self-contained is passed.  This only causes trouble
for distributors (who typically build several variants -- GTK+, Lucid,
-nox and now the GNUstep port) which share the same common binaries
(in Debian shipped in the emacsXX-bin-common package).

This also doesn't make sense for mortal users who wish to install both
a GTK+ and GNUstep Emacs under the same prefix; a perfectly valid
scenario.

2008-11-12  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Under NS, set `exec_prefix' and `libexecdir'
	relative to `ns_appbindir' only if Emacs is configured for a
	self-contained app.


Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.575
diff -u -u -r1.575 configure.in
--- configure.in	7 Nov 2008 06:56:39 -0000	1.575
+++ configure.in	12 Nov 2008 14:56:06 -0000
@@ -1274,10 +1274,10 @@
   with_xft=no
   with_freetype=no
   # set up packaging dirs
-  exec_prefix=${ns_appbindir}
-  libexecdir=${ns_appbindir}/libexec
   if test "${EN_NS_SELF_CONTAINED}" = yes; then
      prefix=${ns_appresdir}
+     exec_prefix=${ns_appbindir}
+     libexecdir=${ns_appbindir}/libexec
   fi
 fi
 CFLAGS="$tmp_CFLAGS"

bug#1335: #1335 - Arch-dependant data should not be installed in the app bundle - Emacs bug report logs

[Adrian Robert]

Hi,

Does this patch not cause an error for you when lines 416-417 in  
Makefile.in (under install-arch-dep target) are executed?  Should ' if  
test -d ' checks similer to the preceding lines be added?

thanks,
Adrian

bug#1335: #1335 - Arch-dependant data should not be installed in the app bundle - Emacs bug report logs

[Yavor Doganov]

tags 1335 + patch
thanks

At Mon, 24 Nov 2008 22:29:20 -0500,
Adrian Robert wrote:
> Does this patch not cause an error for you when lines 416-417 in  
> Makefile.in (under install-arch-dep target) are executed?

Eek!  Not merely an error, the entire working copy is being deleted...
I haven't noticed this because I run "make install" when the tree is
configured with --without-x so these commands are not being run at all
as `ns_appdir' is undefined.

Here's an updated patch, hopefully properly tested this time.


2009-06-26  Yavor Doganov  <yavor@gnu.org>

	Do not install arch-dependent files in the app bundle if
	--disable-ns-self-contained is requested.
	* configure.in: Define `exec_prefix' and `libexecdir' relative to
	`ns_appbindir' only if configured for a self-contained app.
	* Makefile.in (install-arch-dep): Test for the existence of
	libexec in the Emacs.app bundle before executing commands.


Index: Makefile.in
===================================================================
RCS file: /sources/emacs/emacs/Makefile.in,v
retrieving revision 1.374
diff -u -r1.374 Makefile.in
--- Makefile.in	4 May 2009 01:13:20 -0000	1.374
+++ Makefile.in	26 Jun 2009 13:34:48 -0000
@@ -429,10 +429,10 @@
 	    if test -d share/emacs ; then dir=share/emacs/*/*; $(MV_DIRS); fi;\
 	    if test -d share/info ; then dir=share/info; $(MV_DIRS) ; fi ; \
 	    rm -fr share ) ; \
-	  ( cd ${ns_appbindir}/libexec ; dir=emacs/*/*/* ; $(MV_DIRS); \
-	    rm -fr emacs ) ; \
-	  ( cd ${ns_appbindir}/bin ; rm -f emacs emacs-23* ; \
-	    ln -sf ../libexec/* .) ; \
+	  ( cd ${ns_appbindir} ; \
+	    if test -d libexec; then cd libexec ; dir=emacs/*/*/* ; \
+	    $(MV_DIRS); rm -fr emacs; \
+	    cd ../bin; rm -f emacs emacs-23* ; ln -sf ../libexec/* . ; fi) ; \
 	else true ; fi
 
 ## http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg01672.html
--- configure.in	19 Jun 2009 17:10:51 -0000	1.598
+++ configure.in	26 Jun 2009 13:35:00 -0000
@@ -1270,10 +1270,10 @@
   window_system=nextstep
   with_xft=no
   # set up packaging dirs
-  exec_prefix=${ns_appbindir}
-  libexecdir=${ns_appbindir}/libexec
   if test "${EN_NS_SELF_CONTAINED}" = yes; then
      prefix=${ns_appresdir}
+     exec_prefix=${ns_appbindir}
+     libexecdir=${ns_appbindir}/libexec
   fi
 fi
 CFLAGS="$tmp_CFLAGS"

bug#1335: Arch-dependant data should not be installed in the app bundle

[Glenn Morris]

Version: 24.0.92

I am sorry for the huge delay. This is installed now.