unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#5459: Should url-util require url-vars?
@ 2010-01-23 20:36 Lennart Borgman
  2010-01-23 22:50 ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2010-01-23 20:36 UTC (permalink / raw)
  To: 5459

I got these error messages when calling url-retrieve (which is autloaded):

error in process filter:
url-http-content-length-after-change-function: Symbol's value as
variable is void: url-show-status
error in process filter: Symbol's value as variable is void: url-show-status
error in process filter:
url-http-content-length-after-change-function: Symbol's value as
variable is void: url-show-status
error in process filter: Symbol's value as variable is void: url-show-status
...

url-show-status is defined in url-vars.el.
url-http-content-length-after-change-function calls
url-display-percentage which needs url-show-status.

url-display-percentage is defined in url-util.el. Maybe this library
should require url-vars?







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5459: Should url-util require url-vars?
  2010-01-23 20:36 bug#5459: Should url-util require url-vars? Lennart Borgman
@ 2010-01-23 22:50 ` Chong Yidong
  2010-01-24 22:40   ` Lennart Borgman
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2010-01-23 22:50 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: 5459

> url-show-status is defined in url-vars.el.
> url-http-content-length-after-change-function calls
> url-display-percentage which needs url-show-status.
>
> url-display-percentage is defined in url-util.el. Maybe this library
> should require url-vars?

Yes.  Fixed now, thanks.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5459: Should url-util require url-vars?
  2010-01-23 22:50 ` Chong Yidong
@ 2010-01-24 22:40   ` Lennart Borgman
  2010-01-24 22:48     ` Chong Yidong
  2010-01-24 22:49     ` Lennart Borgman
  0 siblings, 2 replies; 6+ messages in thread
From: Lennart Borgman @ 2010-01-24 22:40 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 5459

On Sat, Jan 23, 2010 at 11:50 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
>> url-show-status is defined in url-vars.el.
>> url-http-content-length-after-change-function calls
>> url-display-percentage which needs url-show-status.
>>
>> url-display-percentage is defined in url-util.el. Maybe this library
>> should require url-vars?
>
> Yes.  Fixed now, thanks.


Thanks. Unfortunately there are more trouble. And I suspect serious
trouble. Please reopen the bug.


This is what I get in my *Messages* buffer on w32 after explicitly
loading url-vars.el (I have not rebuilt Emacs yet with your changes):

  (featurep 'url-vars)=t, url-show-status=nil
  error in process filter:
url-http-content-length-after-change-function: Symbol's value as
variable is void: url-show-status

The first line is just from

  (message "(featurep 'url-vars)=%s, url-show-status=%s" (featurep
'url-vars) url-show-status)

The second line looks very strange to me since url-show-status was
defined on the first line and it is defined in url-vars.el.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5459: Should url-util require url-vars?
  2010-01-24 22:40   ` Lennart Borgman
@ 2010-01-24 22:48     ` Chong Yidong
  2010-01-24 22:49     ` Lennart Borgman
  1 sibling, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2010-01-24 22:48 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: 5459

Lennart Borgman <lennart.borgman@gmail.com> writes:

> This is what I get in my *Messages* buffer on w32 after explicitly
> loading url-vars.el (I have not rebuilt Emacs yet with your changes):
>
>   (featurep 'url-vars)=t, url-show-status=nil
>   error in process filter:
> url-http-content-length-after-change-function: Symbol's value as
> variable is void: url-show-status
>
> The first line is just from
>
>   (message "(featurep 'url-vars)=%s, url-show-status=%s" (featurep
> 'url-vars) url-show-status)
>
> The second line looks very strange to me since url-show-status was
> defined on the first line and it is defined in url-vars.el.

Try rebuilding, and then provide an exact, step-by-step recipe to
reproduce the problem, starting from `emacs -Q'.







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5459: Should url-util require url-vars?
  2010-01-24 22:40   ` Lennart Borgman
  2010-01-24 22:48     ` Chong Yidong
@ 2010-01-24 22:49     ` Lennart Borgman
  2010-01-25  3:04       ` Stefan Monnier
  1 sibling, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2010-01-24 22:49 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 5459

On Sun, Jan 24, 2010 at 11:40 PM, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> On Sat, Jan 23, 2010 at 11:50 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
>>> url-show-status is defined in url-vars.el.
>>> url-http-content-length-after-change-function calls
>>> url-display-percentage which needs url-show-status.
>>>
>>> url-display-percentage is defined in url-util.el. Maybe this library
>>> should require url-vars?
>>
>> Yes.  Fixed now, thanks.
>
>
> Thanks. Unfortunately there are more trouble. And I suspect serious
> trouble. Please reopen the bug.
>
>
> This is what I get in my *Messages* buffer on w32 after explicitly
> loading url-vars.el (I have not rebuilt Emacs yet with your changes):
>
>  (featurep 'url-vars)=t, url-show-status=nil
>  error in process filter:
> url-http-content-length-after-change-function: Symbol's value as
> variable is void: url-show-status
>
> The first line is just from
>
>  (message "(featurep 'url-vars)=%s, url-show-status=%s" (featurep
> 'url-vars) url-show-status)
>
> The second line looks very strange to me since url-show-status was
> defined on the first line and it is defined in url-vars.el.


Hm, my bad. I did something like this:

  (let ((url-show-status nil)) ;; do not show download messages
    (require 'url-vars)
    (message "(featurep 'url-vars)=%s, url-show-status=%s" (featurep
'url-vars) url-show-status)
    (url-retrieve ...))

This prevented url-show-status to be defined when loading url-vars.
Placing (require 'url-vars) above the let statement fixed this.

Sorry for the trouble.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5459: Should url-util require url-vars?
  2010-01-24 22:49     ` Lennart Borgman
@ 2010-01-25  3:04       ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2010-01-25  3:04 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: Chong Yidong, 5459

>   (let ((url-show-status nil)) ;; do not show download messages
>     (require 'url-vars)
>     (message "(featurep 'url-vars)=%s, url-show-status=%s" (featurep
> 'url-vars) url-show-status)
>     (url-retrieve ...))

> This prevented url-show-status to be defined when loading url-vars.
> Placing (require 'url-vars) above the let statement fixed this.

This should have given you a warning.


        Stefan






^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-01-25  3:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 20:36 bug#5459: Should url-util require url-vars? Lennart Borgman
2010-01-23 22:50 ` Chong Yidong
2010-01-24 22:40   ` Lennart Borgman
2010-01-24 22:48     ` Chong Yidong
2010-01-24 22:49     ` Lennart Borgman
2010-01-25  3:04       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).