unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 7390@debbugs.gnu.org
Subject: bug#7390: 24.0.50; pos-col-row gives incorrect row
Date: Sat, 13 Nov 2010 16:37:35 -0500	[thread overview]
Message-ID: <8739r4lxb4.fsf@stupidchicken.com> (raw)
In-Reply-To: <83zktcdi7t.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Nov 2010 23:30:46 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> I could revert my change to emacs-23 branch and install it on the
> trunk instead.  (Although I cannot see how this could hurt existing
> code -- did you see Lisp code that actually depends on this?)
>
> E.g., artist.el is broken in the same way as picture.el, when there's
> a header line in the window where you draw.
>
> Many users of posn-col-row only use it to compute the difference
> between two rows -- those will be unaffected by my change in
> posn-col-row.
>
> So I still maintain that the fix in posn-col-row should stay in the
> emacs-23 branch.

OK, but then this should be documented in etc/NEWS, just in case there
is someone who cares about the exact behavior of posn-col-row.  Would
you mind doing that?

Also, we have to remember to change posn-col-row again, when we fix the
deeper problem---the X and Y pixel coordinate mismatch that I described
earlier.





  reply	other threads:[~2010-11-13 21:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-13 17:55 bug#7390: 24.0.50; pos-col-row gives incorrect row Drew Adams
2010-11-13 19:02 ` Eli Zaretskii
2010-11-13 19:17   ` Drew Adams
2010-11-13 21:10   ` Eli Zaretskii
2010-11-13 21:30     ` Eli Zaretskii
2010-11-13 21:37       ` Chong Yidong [this message]
2010-11-13 22:00         ` Eli Zaretskii
2010-11-16 19:59           ` Chong Yidong
2010-12-12  7:15     ` YAMAMOTO Mitsuharu
2010-12-12  7:29       ` Eli Zaretskii
2010-12-12  7:37         ` YAMAMOTO Mitsuharu
2010-12-12 20:47           ` Eli Zaretskii
2010-11-13 21:13   ` Chong Yidong
2010-11-13 21:21     ` Eli Zaretskii
2010-11-13 21:38     ` Drew Adams
2010-11-13 22:31       ` Eli Zaretskii
2010-11-13 21:44     ` Chong Yidong
2010-11-13 21:55       ` Eli Zaretskii
2010-11-14 17:35         ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739r4lxb4.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=7390@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).