bug#7662: 24.0.50; Keybindings for menu items not aligned

bug#7662: 24.0.50; Keybindings for menu items not aligned

[Eli Zaretskii]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your report will be posted to the bug-gnu-emacs@gnu.org mailing list
and the gnu.emacs.bug news group, and at http://debbugs.gnu.org.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

Some of the key bindings shown in in the menu-bar menus are not aligned
properly.  I saw 2: Edit->Copy ("M-w" is 1 column to the left from where
it should have been), and Lisp Interaction->Instrument Function for Debugging.
(The latter problem also shows on the emacs-23 branch.)

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
d:/gnu/bzr/emacs/trunk/etc/DEBUG.


In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-12-17 on HOME-C4E4A596F7
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1255
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o <tab> r t <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug
help-mode easymenu view tooltip ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev button minibuffer faces cus-face files text-properties overlay
md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process multi-tty emacs)

bug#7662: 24.0.50; Keybindings for menu items not aligned

[Chong Yidong]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Some of the key bindings shown in in the menu-bar menus are not aligned
> properly.  I saw 2: Edit->Copy ("M-w" is 1 column to the left from where
> it should have been), and Lisp Interaction->Instrument Function for Debugging.
> (The latter problem also shows on the emacs-23 branch.)

Could this be Windows-only?  I don't see anything out of the ordinary on
a GTK build (screenshot attached).


[-- Attachment #2: emacs-menu.png --]
[-- Type: image/png, Size: 16778 bytes --]

bug#7662: 24.0.50; Keybindings for menu items not aligned

[Eli Zaretskii]

> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: 7662@debbugs.gnu.org
> Date: Tue, 21 Dec 2010 14:53:11 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Some of the key bindings shown in in the menu-bar menus are not aligned
> > properly.  I saw 2: Edit->Copy ("M-w" is 1 column to the left from where
> > it should have been), and Lisp Interaction->Instrument Function for Debugging.
> > (The latter problem also shows on the emacs-23 branch.)
> 
> Could this be Windows-only?

I don't think so, since I see it in the DOS build as well (which uses
neither the Windows "toolkit" nor the w32 code that handles menus).

> I don't see anything out of the ordinary on a GTK build (screenshot
> attached).

Judging by the screenshot, it looks like GTK has its own ideas about
formatting the menu items: it flushes the end of the key sequences all
the way to the right.  If so, it's a small wonder that you don't see
the problem, which happens when the _beginning_ of the key sequences
should be aligned.  That is, I expect to see

  Undo     C-x u
  Cut      C-w
  Copy	   M-w
  Paste    C-y

but instead I see this:

  Undo     C-x u
  Cut      C-w
  Copy	  M-w    <<<<<<<<<<<<<<<<<<<<<<<<<
  Paste    C-y

I suggest to try with a less viral toolkit, or without any toolkit.
The latter should generally exhibit the same behavior as the DOS
build, since they both use the same code to create the menus.  (I
originally suspected that the Windows build hits this because it uses
a proportional font, but of course the DOS build does not, so that's
not it.)

bug#7662: 24.0.50; Keybindings for menu items not aligned

[Eli Zaretskii]

> From: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 21 Dec 2010 07:22:54 -0500
> Cc: 7662@debbugs.gnu.org
> 
>   Undo     C-x u
>   Cut      C-w
>   Copy     M-w
>   Paste    C-y
> 
> but instead I see this:
> 
>   Undo     C-x u
>   Cut      C-w
>   Copy    M-w    <<<<<<<<<<<<<<<<<<<<<<<<<
>   Paste    C-y

Bug squashed.  It affected all menu items that had an explicit `:keys'
attribute: we weren't prepending 2 spaces to the key sequence, like we
did when no `:keys' were present.  E.g., try Texinfo->Update All in
Texinfo mode.

This bug exists in Emacs 23 as well, so I fixed it on the emacs-23
branch (revno 100332).