From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#11068: 24.0.94; Face-remapped background does not extend to end of window Date: Sun, 25 Mar 2012 14:20:57 +0800 Message-ID: <87398x19rq.fsf@gnu.org> References: <1BE52A40-0403-433F-8164-DFDBD6771F80@gmail.com> <83ty1fvc28.fsf@gnu.org> <83obrmtbsy.fsf@gnu.org> <87ty1ekrqy.fsf@gnu.org> <83ehsit63e.fsf@gnu.org> <87mx75z8n6.fsf@gnu.org> <83ty1ds4ye.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332656527 18735 80.91.229.3 (25 Mar 2012 06:22:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2012 06:22:07 +0000 (UTC) Cc: darthandrus@gmail.com, 11068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 25 08:22:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBgq6-0000cU-3S for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2012 08:22:06 +0200 Original-Received: from localhost ([::1]:52402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBgq5-0008HY-8r for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2012 02:22:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBgq2-0008HN-Cr for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2012 02:22:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBgq0-0000zt-IL for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2012 02:22:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBgq0-0000zA-FP for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2012 02:22:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBhK2-0006sA-6C for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2012 02:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Mar 2012 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11068-submit@debbugs.gnu.org id=B11068.133265836726397 (code B ref 11068); Sun, 25 Mar 2012 06:53:02 +0000 Original-Received: (at 11068) by debbugs.gnu.org; 25 Mar 2012 06:52:47 +0000 Original-Received: from localhost ([127.0.0.1]:37436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBhJm-0006rh-EP for submit@debbugs.gnu.org; Sun, 25 Mar 2012 02:52:47 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:56365) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBhJD-0006qz-Ct for 11068@debbugs.gnu.org; Sun, 25 Mar 2012 02:52:45 -0400 Original-Received: from bb121-6-68-206.singnet.com.sg ([121.6.68.206]:38111 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SBgp7-0006o3-KI; Sun, 25 Mar 2012 02:21:06 -0400 In-Reply-To: <83ty1ds4ye.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Mar 2012 06:02:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58117 Archived-At: Eli Zaretskii writes: > Here I disagree: I think we should confine the internal details of > face remapping to lookup_basic_face, instead of spilling our knowledge > about that all over. As you just said above, if face-remapping-alist > is nil, that function returns immediately, so there's nothing lost > here for the "usual" use-case. I don't know how making use of the return value from a previous call to lookup_basic_face (when default_face was assigned) is "spilling our knowledge", but whatever; it's not a important point. > OK, but to be absolutely fair, I must point out that, while the patch > is very simple, it has one non-trivial consequence: when the default > face _is_ remapped, the empty space to the right of any L2R line and > the empty lines beyond EOB are filled with stretch glyphs of a > suitably computed width. Before the patch, there were no glyphs in > those places. So, from the POV of the content of the glyph matrices, > the change introduced by these patches is quite prominent. In > particular, this could potentially affect any code that examines the > glyphs of a glyph matrix; previously, such stretch glyphs were only > present at the left side of R2L glyph rows. Hmm, you're right, that is a non-trivial change. The implications of that are not obvious to me. Maybe we should delay this for post-24.1 then.