From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Date: Thu, 26 Apr 2012 20:38:35 +0200 Message-ID: <87397q8hh8.fsf@gmail.com> References: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> <9DC04CC6E710430F90675022247AF8C1@us.oracle.com> <6D7414BA5657418E9D2AB4D0AA0E71A3@us.oracle.com> <87y5pk53ra.fsf@spindle.srvr.nix> <87ty07hcv7.fsf@gmail.com> <87ipgngi26.fsf@gmail.com> <8029A2B122324A82AEAC6FC2A742F198@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335465669 32437 80.91.229.3 (26 Apr 2012 18:41:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2012 18:41:09 +0000 (UTC) Cc: 11328@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 26 20:41:08 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SNTcq-0000b9-Ds for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Apr 2012 20:41:08 +0200 Original-Received: from localhost ([::1]:40020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNTcp-0000Zk-Pz for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Apr 2012 14:41:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNTcm-0000ZU-Hl for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2012 14:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SNTck-00025T-O7 for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2012 14:41:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNTck-00025N-IK for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2012 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SNTdh-00004s-Vb for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2012 14:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Apr 2012 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11328-submit@debbugs.gnu.org id=B11328.133546567732717 (code B ref 11328); Thu, 26 Apr 2012 18:42:01 +0000 Original-Received: (at 11328) by debbugs.gnu.org; 26 Apr 2012 18:41:17 +0000 Original-Received: from localhost ([127.0.0.1]:54636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNTcy-0008Vc-7J for submit@debbugs.gnu.org; Thu, 26 Apr 2012 14:41:17 -0400 Original-Received: from mail-wi0-f180.google.com ([209.85.212.180]:33814) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNTcw-0008VR-5D for 11328@debbugs.gnu.org; Thu, 26 Apr 2012 14:41:15 -0400 Original-Received: by wibhm17 with SMTP id hm17so1356517wib.15 for <11328@debbugs.gnu.org>; Thu, 26 Apr 2012 11:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:references:user-agent :message-id:mime-version:content-type; bh=+Amap1FTWrjpZrVENs13jn4ELZ1yNbS5SWmo83ohYB4=; b=weIIIIRrslr2y245InC6VpueJCA+HPhhSecyOesb4cwsKKGeIOh5172ZTfkxhbnx6x i3kjmnYXWTSo3hjjwEahoiZ3Qu6BQPKL3QMvaArC3cgwQgagePlhaW6eNzLRSi0XCiRs BaGEKqMznkMiAsUlKqdhvUmYlXsrM0qk/mur8XS2ekjhbd0jtmTGkJedyiACRvNl8GRv w9fpjVvUVBDn6QY2W/sRMygQdMQqA1eyofkrNp3W2mGxYjvNnBQpiknikBplnflXZVNr PmWgYxnrFf/xefDIMWigl2Hhx6ycYKtfIPum32G4RWfReVHXM/+WTxkQVTgVmzhRfjw2 Bn7w== Original-Received: by 10.216.132.216 with SMTP id o66mr4968156wei.14.1335465608505; Thu, 26 Apr 2012 11:40:08 -0700 (PDT) Original-Received: from thierry-MS-7309 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id 17sm371203wis.0.2012.04.26.11.40.06 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Apr 2012 11:40:07 -0700 (PDT) In-Reply-To: <8029A2B122324A82AEAC6FC2A742F198@us.oracle.com> (Drew Adams's message of "Thu, 26 Apr 2012 08:35:49 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59534 Archived-At: "Drew Adams" writes: > As I explained, in the particular case of NAME-CONSTRUCTOR and TARGET the caller > does not in fact ever need (make use of) the _variable_ TARGET. All it needs is > its value, i.e., the value at the time and place that the lambda is constructed, > in `d-do-create-files'. > > So there is no need to include the _variable_ itself in the lambda form. It is > sufficient to use its value there. That is clearer to read and is cleaner code. Yes that is what i wanted to explain. > And there is no need either to pass TARGET as an additional argument to > `d-create-files'. Of course there is no need to do this, it would change nothing, just make the code clearer to use and read. What can be done also is leave `dired-create-files' as it is and modify `dired-do-create-files' to have a generic function usable anywhere (actually it is usable only in dired) and easy to use; It is what I do here. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997