From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#13207: lisp-mnt.el improvements Date: Mon, 17 Dec 2012 22:58:26 +0100 Message-ID: <8738z42vel.fsf@bernoul.li> References: <878v8wve4m.fsf@bernoul.li>, NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355781538 28217 80.91.229.3 (17 Dec 2012 21:58:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2012 21:58:58 +0000 (UTC) Cc: 13207@debbugs.gnu.org To: "Stefan Monnier" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 22:59:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TkiiN-0004Dw-EL for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2012 22:59:11 +0100 Original-Received: from localhost ([::1]:43834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkiiA-0005gc-1g for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2012 16:58:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkii3-0005gX-87 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 16:58:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkihy-0001NT-Mo for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 16:58:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkihy-0001NO-Fe for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 16:58:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TkijC-0006Va-PH for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 17:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2012 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13207-submit@debbugs.gnu.org id=B13207.135578159924988 (code B ref 13207); Mon, 17 Dec 2012 22:00:02 +0000 Original-Received: (at 13207) by debbugs.gnu.org; 17 Dec 2012 21:59:59 +0000 Original-Received: from localhost ([127.0.0.1]:47673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkij3-0006Us-PI for submit@debbugs.gnu.org; Mon, 17 Dec 2012 16:59:59 -0500 Original-Received: from mail-wi0-f170.google.com ([209.85.212.170]:50964) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkiiw-0006Ud-5A for 13207@debbugs.gnu.org; Mon, 17 Dec 2012 16:59:52 -0500 Original-Received: by mail-wi0-f170.google.com with SMTP id hq7so2462375wib.3 for <13207@debbugs.gnu.org>; Mon, 17 Dec 2012 13:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:user-agent:in-reply-to:date :message-id:mime-version:content-type; bh=Sdb8tT9CVWcXVqg+OD1MgrM1rT357fgR51veC7xnwcQ=; b=GaDJgP2rw3RvLTkIXHRWNUOzTVosiWzD71cptbwJ9iEuwN6c606Wag1+YON2kjI9kl fJ/204aQVdybWKZasLQ2M+9ak6rUYuWHZP8Ij/qc7nc/KKMOnKejyHjWte72gWPqw+WQ leAm89qO6GA/t9G4qDE8SOWX5drniHS8kziDVzk0qk8yIPq7LOgHEU92tbWCcXAQVZbC S0s77BuPCI/2uGE17MBzkK+cKt2mM8l3+7cea7i5zLkI/SKY8/qT0+wh08LZmK5jo/Uz c0iotTbaITFxgkpV9c4+m3bfQj89CrQqM+IKIHmswKwONUI3oBMMb91RDbxCsk53YB+C Ahgg== Original-Received: by 10.194.76.165 with SMTP id l5mr19945224wjw.14.1355781508479; Mon, 17 Dec 2012 13:58:28 -0800 (PST) Original-Received: from lem (178-83-148-79.dynamic.hispeed.ch. [178.83.148.79]) by mx.google.com with ESMTPS id t17sm14603087wiv.6.2012.12.17.13.58.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Dec 2012 13:58:27 -0800 (PST) User-agent: mu4e 0.9.9.5-dev4; emacs 24.3.50.1 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68672 Archived-At: >> 3. lm-header, lm-header-multiline: wrap with save-match-data > > This one doesn't sound right. The callers should be fixed instead. Okay. On second though: it wouldn't be very useful to use the match data set by these functions. Why not save the match-data here once so that no caller has to ever worry about it? Is there a general policy that this kinda thing shouldn't be done? >> 4. lm-header-multiline: continuation lines now need to be intended more >> than the first line. E.g: >> ;; Keyword: value >> ;; more value >> This is necessary because some built-in libraries contain things >> like: >> ;; Author: Kenichi HANDA >> ;; (according to ack.texi) >> And some third-party libraries contain things like: >> ;; Keywords: key words >> ;; This file is not part of Emacs >> Among the 3500 packages mirrored on the Emacsmirror there are only >> three where this change results in lines intended as continuation >> lines not to be recognised anymore. At the same time this change >> fixes ~50 errors. > > An important measure is how much breakage/improvement does it introduce > when applied to files that are expected to do thing right (e.g. files in > emacs/lisp and in elpa/packages). I'm OK with making lisp-mnt.el more > forgiving, but it should not come at the cost of those packages that do > things right. The 3500 packages from which I extracted metadata include all built-in and fsf-elpa packages (though I did not process every library, just the "main library" of each package). The three packages affected in a negative way didn't do things right, and they aren't fsf packages. This should be possible ;; Author: Kenichi HANDA ;; (according to ack.texi) and this can be sacrificed ;; Author: Kenichi HANDA ;; Jonas Bernoulli -- Jonas