unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 9898@debbugs.gnu.org
Subject: bug#9898: 24.0.90; doc of :key-sequence
Date: Sat, 08 Feb 2014 21:58:41 -0800	[thread overview]
Message-ID: <8738jsaktq.fsf@building.gnus.org> (raw)
In-Reply-To: <B7475A65554A4B7F8104892076D381EC@us.oracle.com> (Drew Adams's message of "Fri, 28 Oct 2011 11:48:51 -0700")

"Drew Adams" <drew.adams@oracle.com> writes:

> (elisp) Extended Menu Items
>
> "`:key-sequence nil'
>  This property indicates that there is normally no key binding
>  which is equivalent to this menu item.  Using this property saves
>  time in preparing the menu for display, because Emacs does not
>  need to search the keymaps for a keyboard equivalent for this menu
>  item.
>
>  However, if the user has rebound this item's definition to a key
>  sequence, Emacs ignores the `:keys' property and finds the keyboard
>  equivalent anyway."
>
> Should that `:keys' be `:key-sequence'?  Since when do we override :keys
> with whatever the command is bound to?

Looking at the code, it looks to me that the documentation is wrong
here.  But I might be wrong.  The function in question that uses this
stuff is `easy-menu-convert-item-1'.  Somebody should take a look and
decide.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





  reply	other threads:[~2014-02-09  5:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 18:48 bug#9898: 24.0.90; doc of :key-sequence Drew Adams
2014-02-09  5:58 ` Lars Ingebrigtsen [this message]
2017-03-25  3:22   ` npostavs
2021-07-16 13:52     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738jsaktq.fsf@building.gnus.org \
    --to=larsi@gnus.org \
    --cc=9898@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).