unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Glenn Morris <rgm@gnu.org>
Cc: 15991@debbugs.gnu.org
Subject: bug#15991: 24.3.50; Wishlist: Make test suite user-friendlier
Date: Fri, 27 Jun 2014 20:12:38 +0200	[thread overview]
Message-ID: <8738eq8bmx.fsf@gmx.de> (raw)
In-Reply-To: <krbntejqfj.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 27 Jun 2014 11:57:36 -0400")

Glenn Morris <rgm@gnu.org> writes:

>> I believe it is desirable to run the tests unconditionally when invoked
>> via make. People call "make check" for a reason.
>
> I suppose you are right, and this is consistent with how it used to behave.

Nope. When you cal "make check" a second time, no test runs again,
'cause the log files exist already.

>> Maybe you could even offer the test package name as target. Then one
>> could call "make -C test/automated tramp-tests",
>
> You can already do
>
>    make -C test/automated tramp-tests.log

Again, it works only when there is no log file. The second time you
call it, nothing happens:

~/src/emacs> make -C test/automated tramp-tests.log
make: Entering directory `/usr/local/src/emacs/test/automated'
make: `tramp-tests.log' is up to date.
make: Leaving directory `/usr/local/src/emacs/test/automated'

> I don't think removing the ".log" is worth it.

If you want to rerun a test, you must remove the log file
manually. Inconvenient.

>> There is another issue. By redirecting the output to a file, the
>> password prompt for tramp-tests isn't visible anymore. This is a real
>> regression, because these tests are intended to run for different remote
>> file names. Could you pipe the test output through tee or something like
>> this? I don't know how portable this would be, 'tho.
>
> Not sure I understand. Do you want to interact, ie type a password?
> I think tests that require interaction are a Bad Thing.
> Are these optional tests that do not normally run?

Nope. See the commentary section of tramp-test.el. Try

~/src/emacs> env REMOTE_TEMPORARY_FILE_DIRECTORY=/sudo::/tmp make -C test/automated tramp-tests.log

It will ask you for the sudo password, but you don't see the prompt.

Best regards, Michael.





  reply	other threads:[~2014-06-27 18:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 20:04 bug#15991: 24.3.50; Wishlist: Make test suite user-friendlier Eli Zaretskii
2013-11-28 20:13 ` Glenn Morris
2013-11-28 22:32   ` Stefan Monnier
2014-06-26  6:05 ` Glenn Morris
2014-06-26 15:08   ` Eli Zaretskii
2014-06-26 15:20   ` Michael Albinus
2014-06-26 15:42     ` Glenn Morris
2014-06-26 15:49       ` Glenn Morris
2014-06-27  7:23         ` Michael Albinus
2014-06-27  7:50           ` Eli Zaretskii
2014-06-27  8:57             ` Michael Albinus
2014-06-27 15:57           ` Glenn Morris
2014-06-27 18:12             ` Michael Albinus [this message]
2014-06-27 18:24               ` Michael Albinus
2014-06-28  1:13               ` Glenn Morris
2014-06-28 17:12                 ` Glenn Morris
2014-06-29 13:30                   ` Michael Albinus
2014-06-26 16:44   ` Glenn Morris
2014-06-26 16:57     ` Eli Zaretskii
2014-06-26 17:00       ` Glenn Morris
2014-06-27  5:45         ` Andreas Röhler
2014-06-27  6:00           ` Eli Zaretskii
2014-06-27 10:00             ` Andreas Röhler
2014-06-27 10:33               ` Eli Zaretskii
2014-06-28 17:19       ` Glenn Morris
2014-06-28 17:42         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738eq8bmx.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=15991@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).