From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: fgallina@gnu.org (=?UTF-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) Newsgroups: gmane.emacs.bugs Subject: bug#18843: Invalid block indentation in Python mode Date: Sat, 15 Nov 2014 18:21:22 -0300 Message-ID: <87389k5fe5.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416086541 30527 80.91.229.3 (15 Nov 2014 21:22:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Nov 2014 21:22:21 +0000 (UTC) To: 18843-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 15 22:22:13 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XpknM-0001p6-7l for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Nov 2014 22:22:12 +0100 Original-Received: from localhost ([::1]:42068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpknL-0004Gc-RR for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Nov 2014 16:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpknH-0004GS-Mo for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 16:22:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpknC-0007Pb-TP for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 16:22:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpknC-0007PW-QZ for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 16:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XpknC-00038T-ME for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 16:22:02 -0500 In-Reply-To: Resent-From: fgallina@gnu.org (=?UTF-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 18843@debbugs.gnu.org, fgallina@gnu.org, pogonyshev@gmail.com Original-Received: via spool by 18843-done@debbugs.gnu.org id=D18843.141608648611997 (code D ref 18843); Sat, 15 Nov 2014 21:22:02 +0000 Original-Received: (at 18843-done) by debbugs.gnu.org; 15 Nov 2014 21:21:26 +0000 Original-Received: from localhost ([127.0.0.1]:34161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpkmb-00037R-RL for submit@debbugs.gnu.org; Sat, 15 Nov 2014 16:21:26 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:55859) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xpkma-00037J-7F for 18843-done@debbugs.gnu.org; Sat, 15 Nov 2014 16:21:24 -0500 Original-Received: from [190.246.172.180] (port=39218 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1XpkmZ-000663-KC for 18843-done@debbugs.gnu.org; Sat, 15 Nov 2014 16:21:24 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96087 Fixed at 89ebffc in the emacs-24 branch. `python-indent-region` region now follows saner approach, it uses `python-indent-line` and skips special cases: namely block starts, enders and dedenters. The idea is that those mark the base indentation and stuff within them could be re-indented. I tested this approach in few large codebases and the results are quite promising, in fact I found several bad indented stuff thanks to this. PS: I unmerged this from #18796, it's not really the same thing. Thanks for the report, Fabi=C3=A1n