From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#19333: 25.0.50; isearch : don't close overlay ending at point Date: Wed, 10 Dec 2014 07:04:18 +0100 Message-ID: <87388ohwgt.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1418191586 17093 80.91.229.3 (10 Dec 2014 06:06:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 06:06:26 +0000 (UTC) Cc: samologist@gmail.com To: 19333@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 10 07:06:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XyaPh-0006wd-1R for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 07:06:17 +0100 Original-Received: from localhost ([::1]:43572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaPg-00043d-Fh for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 01:06:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaPY-00043N-Fl for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:06:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyaPT-00083s-4Z for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:06:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaPT-00083o-1T for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XyaPS-0004x4-Pa; Wed, 10 Dec 2014 01:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: samologist@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Dec 2014 06:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: samologist@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.141819152518987 (code B ref -1); Wed, 10 Dec 2014 06:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Dec 2014 06:05:25 +0000 Original-Received: from localhost ([127.0.0.1]:60202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyaOn-0004w7-Pe for submit@debbugs.gnu.org; Wed, 10 Dec 2014 01:05:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyaOl-0004vz-Iq for submit@debbugs.gnu.org; Wed, 10 Dec 2014 01:05:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyaOf-0007wu-Pu for submit@debbugs.gnu.org; Wed, 10 Dec 2014 01:05:19 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaOf-0007wq-Mg for submit@debbugs.gnu.org; Wed, 10 Dec 2014 01:05:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaOa-0003zh-Gp for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:05:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyaOU-0007YT-Ch for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:05:08 -0500 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:44712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyaOU-0007Nx-1y for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 01:05:02 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoIHABzih1SkD4Xx/2dsb2JhbABZg1hYs1wGhnWLUAqGCQKBOQEBAQEBfYQCAQEBAwICexMUAwECCjQBBBQnIYgjAQMJCA2wJ5EujwoBhj8ghg2CK4UggUdTHoQwBYQpBo0vgx1ZgUKBDTCELoV+gheDXoNvPjABgQIkgRwBAQE Original-Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 10 Dec 2014 07:04:48 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97124 Archived-At: --=-=-= Content-Type: text/plain Hi, TL;DR: the patch being trivial, maybe it's quicker to just skip to that. Samuel Wales (X-Debbugs-CC'd) reported a problem with a recipe : http://lists.gnu.org/archive/html/emacs-orgmode/2014-11/msg00795.html For the record, here's the message: > === call > emacs -Q --geometry -0+0 --geometry 80x30 --eval '(setq load-path > (append (list (substitute-in-file-name "$delorgsrc/lisp") > (substitute-in-file-name "$delorgsrc/contrib/lisp")) load-path))' > bug-isearch.org > === > here is the org file to use: > === bug-isearch.org > * NAKA lorem > *** REF lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > lorem > *** NAKA lorem > ***** reproduce isearch bug > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf asdfasfdasdfasdfasdf > search for lightly org > === > all those asdf lines should be concatenated into a single line in case > gmail corrupted it. (Additionnal note : the "search for lightly org" should be on that line too.) >From there, hit C-s lightly org RET, then you your window should consist of just the ellipsis, instead of showing the text you just searched for. IMO this recipe shows two problems : - one is in isearch - the other was reported as bug#18197 and I'm still not sure what to do with it. For the first, I think the following trivial patch is a fix (if ok to apply, should it be on the emacs-24 branch?), --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-isearch.el-isearch-open-necessary-overlays-Open-over.patch >From 37506a922382fe1e4806ee8ae9de3aab0a7ade8d Mon Sep 17 00:00:00 2001 From: Nicolas Richard Date: Fri, 5 Dec 2014 13:56:31 +0100 Subject: [PATCH] isearch.el (isearch-open-necessary-overlays): Open overlay ending at point. --- lisp/ChangeLog | 5 +++++ lisp/isearch.el | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 445a461..6af9adb 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-12-05 Nicolas Richard + + * isearch.el (isearch-open-necessary-overlays): Open overlay + ending at point. + 2014-12-10 Lars Magne Ingebrigtsen * files.el (directory-files-recursively): Use diff --git a/lisp/isearch.el b/lisp/isearch.el index c3e473a..ef0c4a7 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2734,7 +2734,7 @@ (defun isearch-open-overlay-temporary (ov) ;; in any of these overlays, se we are safe in this case too. (defun isearch-open-necessary-overlays (ov) (let ((inside-overlay (and (> (point) (overlay-start ov)) - (< (point) (overlay-end ov)))) + (<= (point) (overlay-end ov)))) ;; If this exists it means that the overlay was opened using ;; this function, not by us tweaking the overlay properties. (fct-temp (overlay-get ov 'isearch-open-invisible-temporary))) -- 2.0.4 --=-=-= Content-Type: text/plain In GNU Emacs 25.0.50.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2014-11-28 on localhost Repository revision: 692322388c9f5bdebf2e8c4f7434c1d4769a04cc System Description: Gentoo Base System release 2.2 -- Nicolas Richard --=-=-=--