From: Ivan Shmakov <ivan@siamics.net>
To: 19481@debbugs.gnu.org
Subject: bug#19481: package.el: support .tar archives featuring a pax_global_header entry
Date: Sat, 31 Jan 2015 11:05:48 +0000 [thread overview]
Message-ID: <87386ri50z.fsf_-_@violet.siamics.net> (raw)
In-Reply-To: <83zj8zjq97.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jan 2015 10:41:56 +0200")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov Date: Wed, 28 Jan 2015 20:54:33 +0000
>> Please consider the revised patch MIMEd.
>> * lisp/tar-mode.el (tar-header-extractable-p): New function.
>> (tar-untar-buffer): Use it; or use the value of the new optional
>> argument instead.
>> * lisp/emacs-lisp/package.el (package-untar-buffer): Use
>> tar-header-extractable-p.
>> (package-tar-file-info): Consider the second file name in the
>> archive if the first one has no directory component.
> Thanks.
> Can we have a test suite for this file,
Which of the two? (Or three, to count the .tar file produced by
$ git archive.)
> and in particular for these changes?
I hope to come with a suitable addition for
test/automated/package-test.el shortly. Or do you suggest
adding a test suite for tar-mode as well?
FTR, the two changes I suggest are not /inter/dependent, so I
intend to push them as two separate commits. (And I wonder if
eit makes sense to now file a separate Severity: wishlist bug
report for tar-header-extractable-p, so to provide a somewhat
extended background for the feature.)
> Failing that, please describe how you tested these changes.
I’ve tested these using my MW package, like:
• C-x b *new-buffer* RET;
• M-x cd RET ~/devel/mw-el-2015/ RET;
• C-u M-! git archive --prefix=mw-0.2/ --format=tar
HEAD 2> /dev/null RET;
• M-x tar-mode RET;
• M-x package-install-from-buffer RET.
> Otherwise, I have no comments, and no objections to commit this, once
> we are sure it doesn't break anything.
ACK, thanks.
--
FSF associate member #7257 np. La vita — Roberto Ricioppo … B6A0 230E 334A
next prev parent reply other threads:[~2015-01-31 11:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 17:55 bug#19481: package.el: support .tar archives featuring a pax_global_header entry Ivan Shmakov
2015-01-01 18:27 ` Eli Zaretskii
2015-01-01 18:49 ` Ivan Shmakov
2015-01-28 20:54 ` Ivan Shmakov
2015-01-31 8:41 ` Eli Zaretskii
2015-01-31 11:05 ` Ivan Shmakov [this message]
2015-01-31 11:22 ` Eli Zaretskii
2015-02-07 20:10 ` bug#19481: new tar-header-extractable-p, to use in tar-untar-buffer Ivan Shmakov
2015-02-07 20:26 ` Eli Zaretskii
2016-02-23 11:30 ` Lars Ingebrigtsen
2019-06-25 20:53 ` bug#19481: package.el: support .tar archives featuring a pax_global_header entry Lars Ingebrigtsen
2020-01-20 18:35 ` Stefan Monnier
2020-08-13 9:01 ` Lars Ingebrigtsen
2020-08-19 13:42 ` Lars Ingebrigtsen
2015-01-01 18:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87386ri50z.fsf_-_@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19481@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).