bug#19587: shr: produces an extra newline before a block element in <li />

bug#19587: shr: produces an extra newline before a block element in <li />

[Ivan Shmakov]

Package:  emacs
Severity: minor

	As of ec7605b4b137 (2015-01-10 16:54:24 +0000), shr produces an
	extra newline before a “block” element which is the first child
	to a <li /> element.  Consider, e. g.:

(with-temp-buffer
  (let ((r
         (shr-tag-ul
          '(ul nil
               (li nil (div nil "One item."))
               (li nil (div nil "Another item."))))))
    (cons r (buffer-string))))
(nil . "\
• 
  One item.
• 
  Another item.\n\n")

	There, I’d rather expect no newline between the bullet and the
	div elements’ contents, like:

(nil . "\
• One item.
• Another item.\n\n")

	Somewhat surprisingly, this produces a still less consistent
	result when the p elements are used:

(with-temp-buffer
  (let ((r
         (shr-tag-ul
          '(ul nil
               (li nil (p nil "One item."))
               (li nil (p nil "Another item."))
               (li nil
                   (p nil "One more item.")
                   (p nil "And one more paragraph to the same item."))))))
    (cons r (buffer-string))))
(nil . "\
* 
  One item.

*   Another item.

*   One more item.

  And one more paragraph to the same item.\n\n")

	I’d rather expect it to be formatted as follows:

(nil . "\
* One item.

* Another item.

* One more item.

  And one more paragraph to the same item.\n\n")

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

bug#19587: shr: produces an extra newline before a block element in <li />

[Lars Ingebrigtsen]

Ivan Shmakov <ivan@siamics.net> writes:

> Package:  emacs
> Severity: minor
>
> 	As of ec7605b4b137 (2015-01-10 16:54:24 +0000), shr produces an
> 	extra newline before a “block” element which is the first child
> 	to a <li /> element.  Consider, e. g.:
>
> (with-temp-buffer
>   (let ((r
>          (shr-tag-ul
>           '(ul nil
>                (li nil (div nil "One item."))
>                (li nil (div nil "Another item."))))))
>     (cons r (buffer-string))))

Do you have HTML that demonstrates this problem?  The forms no longer
work since the DOM changed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19587: shr: produces an extra newline before a block element in <li />

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:

 >> As of ec7605b4b137 (2015-01-10 16:54:24 +0000), shr produces an
 >> extra newline before a “block” element which is the first child to a
 >> <li /> element.  Consider, e. g.:

 >> (with-temp-buffer
 >>   (let ((r
 >>          (shr-tag-ul
 >>           '(ul nil
 >>                (li nil (div nil "One item."))
 >>                (li nil (div nil "Another item."))))))
 >>     (cons r (buffer-string))))

 > Do you have HTML that demonstrates this problem?

	I can no longer reproduce the bug as of 1dcf9a5d.  An example
	HTML document is MIMEd just in case.

 > The forms no longer work since the DOM changed.

	?

-- 
FSF associate member #7257  http://am-1.org/~ivan/      … 3013 B6A0 230E 334A

[-- Attachment #2: Type: text/html, Size: 182 bytes --]

bug#19587: shr: produces an extra newline before a block element in <li />

[Ivan Shmakov]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

>>>>> Ivan Shmakov <ivan@siamics.net> writes:
>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:

 >>> As of ec7605b4b137 (2015-01-10 16:54:24 +0000), shr produces an
 >>> extra newline before a “block” element which is the first child to
 >>> a <li /> element.  Consider, e. g.:

 >>> (with-temp-buffer
 >>>   (let ((r
 >>>          (shr-tag-ul
 >>>           '(ul nil
 >>>                (li nil (div nil "One item."))
 >>>                (li nil (div nil "Another item."))))))
 >>>     (cons r (buffer-string))))

 >> Do you have HTML that demonstrates this problem?

 > I can no longer reproduce the bug as of 1dcf9a5d.  An example
 > HTML document is MIMEd just in case.

	Correction: I still can reproduce this by using a <div />
	element; consider the document MIMEd.

-- 
FSF associate member #7257  http://am-1.org/~ivan/      … 3013 B6A0 230E 334A

[-- Attachment #2: Type: text/html, Size: 195 bytes --]

bug#19587: shr: produces an extra newline before a block element in <li />

[Lars Ingebrigtsen]

Ivan Shmakov <ivan@siamics.net> writes:

> 	Correction: I still can reproduce this by using a <div />
> 	element; consider the document MIMEd.

This should now be fixed in emacs-25.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no