From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#20489: 25.0.50; next-error-find-buffer chooses non-current buffer without good reason Date: Fri, 29 Jan 2016 01:59:45 +0200 Organization: LINKOV.NET Message-ID: <8737th5kt6.fsf@mail.linkov.net> References: <86wq0q602w.fsf@yandex.ru> <87oacaiszd.fsf@mail.linkov.net> <56A5BF79.909@yandex.ru> <87zivtqq81.fsf@mail.linkov.net> <56A6B171.7080504@yandex.ru> <87y4bbol9h.fsf@mail.linkov.net> <56A82ECE.6050609@yandex.ru> <87powmd410.fsf@mail.linkov.net> <56A95281.9080205@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1454026466 15486 80.91.229.3 (29 Jan 2016 00:14:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jan 2016 00:14:26 +0000 (UTC) Cc: 20489@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 29 01:14:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOwhY-00082U-Oj for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jan 2016 01:14:12 +0100 Original-Received: from localhost ([::1]:59166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOwhV-0007tJ-0y for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Jan 2016 19:14:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOwhR-0007tD-A1 for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2016 19:14:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOwhO-0000gZ-3T for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2016 19:14:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOwhO-0000gV-0c for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2016 19:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aOwhN-0006WM-OT for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2016 19:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jan 2016 00:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20489-submit@debbugs.gnu.org id=B20489.145402639524999 (code B ref 20489); Fri, 29 Jan 2016 00:14:01 +0000 Original-Received: (at 20489) by debbugs.gnu.org; 29 Jan 2016 00:13:15 +0000 Original-Received: from localhost ([127.0.0.1]:40118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOwgd-0006V9-DB for submit@debbugs.gnu.org; Thu, 28 Jan 2016 19:13:15 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:44101 helo=homiemail-a39.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOwgc-0006V1-4u for 20489@debbugs.gnu.org; Thu, 28 Jan 2016 19:13:14 -0500 Original-Received: from homiemail-a39.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTP id EB987150074; Thu, 28 Jan 2016 16:13:12 -0800 (PST) Original-Received: from localhost.linkov.net (85.253.170.103.cable.starman.ee [85.253.170.103]) (Authenticated sender: jurta@jurta.org) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTPA id 1ED11150078; Thu, 28 Jan 2016 16:13:11 -0800 (PST) In-Reply-To: <56A95281.9080205@yandex.ru> (Dmitry Gutov's message of "Thu, 28 Jan 2016 02:28:01 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112067 Archived-At: > Maybe it's a good idea, but I'm not sure how to enforce something like > that, to be able to rely on it. And a small arrow in one window is not > a great indicator anyway. A good indication could be provided by a new global minor mode =E2=80=98global-next-error-minor-mode=E2=80=99 showing in the mode line the currently active navigation, and allowing switching to another navigation. > The rule#1, as written, also poorly interacts with Flycheck-like use > cases. Are you going to comment on that part discussion? Flycheck provides its own keybinding =E2=80=98C-c ! n=E2=80=99 for =E2=80= =98flycheck-next-error=E2=80=99, so really there is no problem. A real problem is when a navigational buffer does exist, but it's hidden. IIUC, due to this problem you reverted next-error integration in xref, ri= ght? > We can also realize that the rule #1 is an attempt to do the following:= if > next-error-last-buffer is no longer visible, try to pick a navigational > buffer among the currently visible ones. You mean next-error-last-buffer is no longer visible _on the selected fra= me_? > However, the rule tries to limit the number of visible navigational buf= fer > to one, and aborts otherwise. I think that's because it doesn't know an= y > better way to distinguish between navigational buffers and plain > file-visiting buffers that have next-error-function set locally > (navigational buffers can also be file-visiting, as in the cases of > change-log-mode and diff-mode). The new variable that I proposed > would help. Yes, this is because it's hard to find a better way, and I'm not sure how next-error-function-nonlocal could help, because sometimes a navigati= on might visit another non-file navigational buffer, e.g. multi-occur visiting a *compilation* buffer.