From: npostavs@users.sourceforge.net
To: Drew Adams <drew.adams@oracle.com>
Cc: 25777@debbugs.gnu.org
Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point
Date: Thu, 02 Mar 2017 21:09:12 -0500 [thread overview]
Message-ID: <8737evaz7b.fsf@users.sourceforge.net> (raw)
In-Reply-To: <a5391386-ea05-4239-83dd-e80a48424871@default> (Drew Adams's message of "Thu, 2 Mar 2017 10:13:36 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
>> My suggestion, since I think we've both had our say and are
>> unlikely to convince one another on the level of principle
>> or guideline, is for you to please make the fix.
>>
>> Since it is you who will kindly make the actual code change
>> and commit, you should/can do it however you like. I have
>> no problem with that.
>>
>> But do you really need another patch for that, especially
>> since wrapping widely, a single time, is so much simpler? ;-)
>> Could you please make the change? Your way is fine by me,
>> for this. Thx.
>
> Here is a possible doc string for the renamed `rectangle-pos-cols':
Yeah, the doc string is the tricky part.
>
> "Return cons (START-COLUMN . END-COLUMN) of columns delimiting a rectangle.
I think the first line is too long.
> START and END are buffer positions of the rectangle corners.
>
> Optional argument WINDOW is the window displaying the rectangle.
> It defaults to the selected window."
>
> I'm not sure it is accurate, but I think so. (I'm no expert on this.)
And looking at the function body again, I think it's checking some other
things, and seems to have some side effects with respect to the current
rectangle.
next prev parent reply other threads:[~2017-03-03 2:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 17:51 bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point Drew Adams
2017-02-19 17:38 ` Drew Adams
2017-02-27 1:37 ` npostavs
2017-02-27 6:24 ` Drew Adams
2017-02-27 13:44 ` npostavs
2017-02-27 17:51 ` Drew Adams
2017-02-27 18:50 ` Noam Postavsky
2017-02-27 19:21 ` Drew Adams
2017-02-27 19:47 ` Noam Postavsky
2017-02-27 20:35 ` Drew Adams
2017-02-28 4:57 ` npostavs
2017-02-28 15:11 ` Drew Adams
2017-03-02 1:21 ` npostavs
2017-03-02 2:32 ` Drew Adams
2017-03-02 18:13 ` Drew Adams
2017-03-03 2:09 ` npostavs [this message]
2017-03-03 6:29 ` Drew Adams
2017-03-03 13:28 ` npostavs
2017-03-03 16:44 ` Drew Adams
2017-03-03 18:16 ` Noam Postavsky
2017-03-03 19:17 ` Drew Adams
2019-06-24 17:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737evaz7b.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25777@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).