From: Alex Branham <branham@utexas.edu>
To: 27341@debbugs.gnu.org
Subject: bug#27341: updated patch to fix docstring
Date: Tue, 13 Jun 2017 11:24:25 +0200 [thread overview]
Message-ID: <8737b4grzq.fsf@utexas.edu> (raw)
In-Reply-To: <8760g1xxhw.fsf@utexas.edu>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
Hi -
I realized I forgot to update the docstring; this patch incorporates that change as well
Alex
From 4545b2fb1d6f047b05cbb1e19a50fb09809d5a31 Mon Sep 17 00:00:00 2001
From: Alex Branham <branham@utexas.edu>
Date: Tue, 13 Jun 2017 11:21:35 +0200
Subject: [PATCH] eww-search-words prompts user for search if region inactive
---
lisp/net/eww.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index fe31657914..aa358dce0f 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -313,10 +313,13 @@ word(s) will be searched for via `eww-search-prefix'."
;;;###autoload
(defun eww-search-words (&optional beg end)
- "Search the web for the text between BEG and END.
+ "If region is active, search the web for the text between BEG and END.
+Else, prompt the user for a search string.
See the `eww-search-prefix' variable for the search engine used."
(interactive "r")
- (eww (buffer-substring beg end)))
+ (if (region-active-p)
+ (eww (buffer-substring beg end))
+ (eww (read-string "Query: "))))
(defun eww-open-in-new-buffer ()
"Fetch link at point in a new EWW buffer."
--
2.13.1
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-eww-search-words-prompt-user-for-search-if-region.patch --]
[-- Type: text/x-diff, Size: 1069 bytes --]
From 4545b2fb1d6f047b05cbb1e19a50fb09809d5a31 Mon Sep 17 00:00:00 2001
From: Alex Branham <branham@utexas.edu>
Date: Tue, 13 Jun 2017 11:21:35 +0200
Subject: [PATCH] eww-search-words prompts user for search if region inactive
---
lisp/net/eww.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index fe31657914..aa358dce0f 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -313,10 +313,13 @@ word(s) will be searched for via `eww-search-prefix'."
;;;###autoload
(defun eww-search-words (&optional beg end)
- "Search the web for the text between BEG and END.
+ "If region is active, search the web for the text between BEG and END.
+Else, prompt the user for a search string.
See the `eww-search-prefix' variable for the search engine used."
(interactive "r")
- (eww (buffer-substring beg end)))
+ (if (region-active-p)
+ (eww (buffer-substring beg end))
+ (eww (read-string "Query: "))))
(defun eww-open-in-new-buffer ()
"Fetch link at point in a new EWW buffer."
--
2.13.1
next prev parent reply other threads:[~2017-06-13 9:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 11:21 bug#27341: eww-search-words should prompt if region inactive Alex Branham
2017-06-13 9:24 ` Alex Branham [this message]
2017-06-25 14:29 ` bug#27341: updated patch to fix docstring npostavs
2017-06-26 14:00 ` Alex Branham
2017-06-26 23:50 ` npostavs
2017-06-27 5:32 ` Alex Branham
2017-06-27 13:23 ` Alex Branham
2017-06-30 0:54 ` npostavs
2017-06-30 6:25 ` Alex Branham
2017-07-02 18:32 ` npostavs
2017-07-02 18:45 ` Alex Branham
2017-07-02 19:13 ` npostavs
2017-07-02 19:25 ` Alex Branham
2017-07-02 20:23 ` npostavs
2017-06-27 14:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737b4grzq.fsf@utexas.edu \
--to=branham@utexas.edu \
--cc=27341@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).