From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27408: 26.0.50; macro setq-local does not have a debug declaration Date: Sat, 17 Jun 2017 15:45:46 -0400 Message-ID: <8737ays8id.fsf@users.sourceforge.net> References: <20170617134409.GC7178@seven> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497728714 9070 195.159.176.226 (17 Jun 2017 19:45:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 19:45:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27408@debbugs.gnu.org To: "Stefan-W. Hahn" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 17 21:45:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMJef-00025D-Hw for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 21:45:09 +0200 Original-Received: from localhost ([::1]:36107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMJek-0006YW-Nq for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 15:45:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMJed-0006Wr-3n for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 15:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMJeY-00012E-8D for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 15:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51013) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMJeY-00011r-3L for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 15:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMJeX-000058-N0 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 15:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27408-submit@debbugs.gnu.org id=B27408.149772865732714 (code B ref 27408); Sat, 17 Jun 2017 19:45:01 +0000 Original-Received: (at 27408) by debbugs.gnu.org; 17 Jun 2017 19:44:17 +0000 Original-Received: from localhost ([127.0.0.1]:53690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMJdp-0008VV-Gl for submit@debbugs.gnu.org; Sat, 17 Jun 2017 15:44:17 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:34982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMJdn-0008VA-Gc; Sat, 17 Jun 2017 15:44:16 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id k93so46007925ioi.2; Sat, 17 Jun 2017 12:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+7fbF+jEvabFzgmivZK86zkrLHUWjWKm9rtJ9oCvsN8=; b=j15KABZCrAVI+3xMZ+IpCdNFUgMg7rzGhzy2IVcOjELZAkaJaEv8qm3GOe9jXIfEaT cGaj/dNQMHDvVgvVWfAhzhavSCOfhVUSTv965T5/iT0WmyRCbaiAXiPfXx9Zvy4MkdON nZ+3GbVV1IBfGevKUlKflJa0JgwJANhG4SIh9BqMtmyAWqN1Amx/D6hz6TKoFddS8/Jv oFzlKIYtpKZDIBvo0D9VuSjnwohIFWo22n/03K0sf0oR/SGkVASKZHkmHLXEiitVMos3 z/TQMyAwHebpuqc73rJATOFDqDHzZz7YDApnFRAONe5tFkxXFPBSUIEzSjFuO6KKDIGN GUdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+7fbF+jEvabFzgmivZK86zkrLHUWjWKm9rtJ9oCvsN8=; b=tZQzWalvGrhFGvBGLCLN4qde86rzyR4w5+LoGUlHrCFnZaxuNfVZUwXuvv20GN6czk nCkb5Sv+UiWg0xPZiW/tIWDrgFIb5ROXIqazxQKdr4rEIH1aP1vExWPhm4EzREp+1B55 CnioIQ8Gfj3Myloz0sENxEn9z2VSveQ4dJpW5aA7p/oMe+wsVwN6bM2Z2k4oR++LGWmN amgqAZ4AG7fNsFNFhZMW9NUpx8S/uHqzPtWOqceVzRz677Jwd9kYAF+94JBh+i6kzShC bWnrUcC8jZVnU9LEsXnFRqpAb7sNKb/0X+tXiOyNHOgdRX9uJgcXL3XyC6ubkh9yR5cB MOqA== X-Gm-Message-State: AKS2vOyQ0/LRvUvsEsjjuFwo8SxUlik6sw+o7ZouMtE3ASvIbQ3EZkMJ 0OHksNdZXVopggH7 X-Received: by 10.107.47.163 with SMTP id v35mr15191032iov.201.1497728649560; Sat, 17 Jun 2017 12:44:09 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 72sm3274972iok.12.2017.06.17.12.44.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Jun 2017 12:44:09 -0700 (PDT) In-Reply-To: <20170617134409.GC7178@seven> (Stefan-W. Hahn's message of "Sat, 17 Jun 2017 15:44:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133711 Archived-At: severity 27408 minor tags 27408 + confirmed quit "Stefan-W. Hahn" writes: > Also I'm not sure it is worth to have a debug declaration for every > macro, but I think for setq-local it makes sense, see attached patch. Probably most macros should have a declaration, assuming someone takes the time to make one (if nobody makes one, I would take that as a sign it's not important). A few, like `declare-function', will probably never really need one. I haven't looked through the whole list, but I guess `woman-pop' and `woman-push' should be replaced with plain `pop' and `push'. > (defmacro setq-local (var val) > "Set variable VAR to value VAL in current buffer." > ;; Can't use backquote here, it's too early in the bootstrap. > + (declare (debug symbolp form)) > (list 'set (list 'make-local-variable (list 'quote var)) val)) I get a compile failure after applying this: ELC ../../emacs-master/lisp/subr.elc Reloading stale subr.el Loading /home/npostavs/src/emacs/emacs-master/lisp/subr.el (source)... Eager macro-expansion failure: (wrong-number-of-arguments (3 . 3) 4) Eager macro-expansion failure: (wrong-number-of-arguments (3 . 3) 4) In toplevel form: ../../emacs-master/lisp/subr.el:121:1:Error: Wrong number of arguments: (3 . 3), 4