From: Michael Albinus <michael.albinus@gmx.de>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 27746@debbugs.gnu.org
Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE
Date: Tue, 18 Jul 2017 09:04:48 +0200 [thread overview]
Message-ID: <87379u444v.fsf@detlef> (raw)
In-Reply-To: <87eftepkm3.fsf@chinook> (Gemini Lasswell's message of "Mon, 17 Jul 2017 19:03:16 -0700")
Gemini Lasswell <gazally@runbox.com> writes:
Hi Gemini,
> There are places in the test code in Emacs which use the existence of
> the NIX_STORE environment variable to change test behavior when
> running on Hydra. However, Emacs should have a different and more
> specific test for whether it is running on Hydra, so that those
> behavior changes don't happen on other machines running NixOS or the
> Nix package manager.
I agree. Checking the existence of $NIX_STORE is just a heuristic. A
better approach might be setting an environment variable or so in the
Emacs recipe for hydra.
Glenn?
> But it would be more generally correct to look at the value of
> NIX_STORE on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points
> to.
The tests running on hydra use always the mockup file name
(format "/mock::%s" temporary-file-directory)
This is on the local host; a proper test for hydra would be sufficient.
Best regards, Michael.
next prev parent reply other threads:[~2017-07-18 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 2:03 bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Gemini Lasswell
2017-07-18 7:04 ` Michael Albinus [this message]
2017-07-18 16:56 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379u444v.fsf@detlef \
--to=michael.albinus@gmx.de \
--cc=27746@debbugs.gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).