* bug#27569: delete-selection on yank via popup-menu
@ 2017-07-03 23:15 Tak Kunihiro
2017-07-03 23:36 ` npostavs
0 siblings, 1 reply; 8+ messages in thread
From: Tak Kunihiro @ 2017-07-03 23:15 UTC (permalink / raw)
To: 27569; +Cc: Kunihiro Tak
I want to yank via popup-menu with delete-selection-mode.
Problem is yanking via popup-menu does not delete region.
emacs -Q
(defun popup-edit-menu ()
(interactive)
(popup-menu menu-bar-edit-menu))
(define-key global-map [mouse-3] 'popup-edit-menu)
(delete-selection-mode 1)
1. kill something
2. select text (activate region) to be replaced
3. choose yank in popup-menu via mouse-3
Problem: Selected text by (2) is not deleted.
I barely see problem is that on delete-selection-pre-hook,
this-command is `popup-edit-menu' instead `yank'.
Is there a way to solve the problem?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27569: delete-selection on yank via popup-menu
2017-07-03 23:15 bug#27569: delete-selection on yank via popup-menu Tak Kunihiro
@ 2017-07-03 23:36 ` npostavs
2017-07-04 23:11 ` Tak Kunihiro
0 siblings, 1 reply; 8+ messages in thread
From: npostavs @ 2017-07-03 23:36 UTC (permalink / raw)
To: Tak Kunihiro; +Cc: 27569
Tak Kunihiro <tkk@misasa.okayama-u.ac.jp> writes:
> I want to yank via popup-menu with delete-selection-mode.
> Problem is yanking via popup-menu does not delete region.
>
> emacs -Q
> (defun popup-edit-menu ()
> (interactive)
> (popup-menu menu-bar-edit-menu))
> (define-key global-map [mouse-3] 'popup-edit-menu)
> (delete-selection-mode 1)
>
> 1. kill something
> 2. select text (activate region) to be replaced
> 3. choose yank in popup-menu via mouse-3
>
> Problem: Selected text by (2) is not deleted.
>
> I barely see problem is that on delete-selection-pre-hook,
> this-command is `popup-edit-menu' instead `yank'.
>
> Is there a way to solve the problem?
This seems to work, though I'm not sure if it's the right way. Perhaps
`this-command' should be setq instead of let-bound? Will running
pre-command-hook twice be a problem? etc...
--- i/lisp/menu-bar.el
+++ w/lisp/menu-bar.el
@@ -2360,6 +2360,8 @@ (defun popup-menu (menu &optional position prefix from-menu-bar)
;; `setup-specified-language-environment', for instance,
;; expects this to be set from a menu keymap.
(setq last-command-event (car (last event)))
+ (let ((this-command cmd))
+ (run-hook 'pre-command-hook))
;; mouse-major-mode-menu was using `command-execute' instead.
(call-interactively cmd))))
^ permalink raw reply [flat|nested] 8+ messages in thread* bug#27569: delete-selection on yank via popup-menu
2017-07-03 23:36 ` npostavs
@ 2017-07-04 23:11 ` Tak Kunihiro
2017-07-11 7:59 ` Tak Kunihiro
0 siblings, 1 reply; 8+ messages in thread
From: Tak Kunihiro @ 2017-07-04 23:11 UTC (permalink / raw)
To: npostavs; +Cc: 27569, tkk
>> I want to yank via popup-menu with delete-selection-mode.
>> Problem is yanking via popup-menu does not delete region.
>>
>> emacs -Q
>> (defun popup-edit-menu ()
>> (interactive)
>> (popup-menu menu-bar-edit-menu))
>> (define-key global-map [mouse-3] 'popup-edit-menu)
>> (delete-selection-mode 1)
>>
>> 1. kill something
>> 2. select text (activate region) to be replaced
>> 3. choose yank in popup-menu via mouse-3
>>
>> Problem: Selected text by (2) is not deleted.
>>
>> I barely see problem is that on delete-selection-pre-hook,
>> this-command is `popup-edit-menu' instead `yank'.
>>
>> Is there a way to solve the problem?
>
> This seems to work, though I'm not sure if it's the right way. Perhaps
> `this-command' should be setq instead of let-bound? Will running
> pre-command-hook twice be a problem? etc...
>
> --- i/lisp/menu-bar.el
> +++ w/lisp/menu-bar.el
> @@ -2360,6 +2360,8 @@ (defun popup-menu (menu &optional position prefix from-menu-bar)
> ;; `setup-specified-language-environment', for instance,
> ;; expects this to be set from a menu keymap.
> (setq last-command-event (car (last event)))
> + (let ((this-command cmd))
> + (run-hooks 'pre-command-hook))
> ;; mouse-major-mode-menu was using `command-execute' instead.
> (call-interactively cmd))))
Although I cannot comment on what you worry, it works well for me.
Thank you for the fix.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27569: delete-selection on yank via popup-menu
2017-07-04 23:11 ` Tak Kunihiro
@ 2017-07-11 7:59 ` Tak Kunihiro
2017-07-12 1:12 ` npostavs
0 siblings, 1 reply; 8+ messages in thread
From: Tak Kunihiro @ 2017-07-11 7:59 UTC (permalink / raw)
To: npostavs; +Cc: 27569, tkk
Could you push to the master?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27569: delete-selection on yank via popup-menu
2017-07-11 7:59 ` Tak Kunihiro
@ 2017-07-12 1:12 ` npostavs
2017-07-18 4:35 ` Tak Kunihiro
0 siblings, 1 reply; 8+ messages in thread
From: npostavs @ 2017-07-12 1:12 UTC (permalink / raw)
To: Tak Kunihiro; +Cc: 27569
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
tags 27569 + patch
quit
Tak Kunihiro <tkk@misasa.okayama-u.ac.jp> writes:
> Could you push to the master?
Okay, I'll wait a couple more days and then push the following (I think
doing setq on this-command makes more sense than let-binding after all).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1122 bytes --]
From 52c16f83b6781c83676507c165e69aaad0a3b2fd Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Tue, 11 Jul 2017 21:09:10 -0400
Subject: [PATCH v2] Let delete-selection-mode work with popup-menu commands
(Bug#27569)
* lisp/menu-bar.el (popup-menu): Run `pre-command-hook' with
`this-command' set to the selected command.
---
| 4 ++++
1 file changed, 4 insertions(+)
--git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 9c7bcffbaa..107043b501 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -2360,6 +2360,10 @@ (defun popup-menu (menu &optional position prefix from-menu-bar)
;; `setup-specified-language-environment', for instance,
;; expects this to be set from a menu keymap.
(setq last-command-event (car (last event)))
+ ;; Update `this-command' and run `pre-command-hook' so that
+ ;; things like `delete-selection-pre-hook' will work correctly.
+ (setq this-command cmd)
+ (run-hook 'pre-command-hook)
;; mouse-major-mode-menu was using `command-execute' instead.
(call-interactively cmd))))
--
2.11.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* bug#27569: delete-selection on yank via popup-menu
2017-07-12 1:12 ` npostavs
@ 2017-07-18 4:35 ` Tak Kunihiro
2017-07-18 10:43 ` npostavs
0 siblings, 1 reply; 8+ messages in thread
From: Tak Kunihiro @ 2017-07-18 4:35 UTC (permalink / raw)
To: npostavs; +Cc: 27569, tkk
The patch works well in my computer. Is it time to push?
> tags 27569 + patch
> quit
>
> Tak Kunihiro <tkk@misasa.okayama-u.ac.jp> writes:
>
>> Could you push to the master?
>
> Okay, I'll wait a couple more days and then push the following (I think
> doing setq on this-command makes more sense than let-binding after all).
>
> * lisp/menu-bar.el (popup-menu): Run `pre-command-hook' with
> `this-command' set to the selected command.
> ---
> lisp/menu-bar.el | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
> index 9c7bcffbaa..107043b501 100644
> --- a/lisp/menu-bar.el
> +++ b/lisp/menu-bar.el
> @@ -2360,6 +2360,10 @@ (defun popup-menu (menu &optional position prefix from-menu-bar)
> ;; `setup-specified-language-environment', for instance,
> ;; expects this to be set from a menu keymap.
> (setq last-command-event (car (last event)))
> + ;; Update `this-command' and run `pre-command-hook' so that
> + ;; things like `delete-selection-pre-hook' will work correctly.
> + (setq this-command cmd)
> + (run-hook 'pre-command-hook)
> ;; mouse-major-mode-menu was using `command-execute' instead.
> (call-interactively cmd))))
>
> --
> 2.11.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-22 14:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-03 23:15 bug#27569: delete-selection on yank via popup-menu Tak Kunihiro
2017-07-03 23:36 ` npostavs
2017-07-04 23:11 ` Tak Kunihiro
2017-07-11 7:59 ` Tak Kunihiro
2017-07-12 1:12 ` npostavs
2017-07-18 4:35 ` Tak Kunihiro
2017-07-18 10:43 ` npostavs
2017-07-22 14:40 ` npostavs
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).