* bug#27890: 26.0.50; describe-font does not use Help buffer history
@ 2017-07-31 21:25 Alex
2017-08-05 23:05 ` Alex
0 siblings, 1 reply; 8+ messages in thread
From: Alex @ 2017-07-31 21:25 UTC (permalink / raw)
To: 27890
describe-font does not add to the *Help* buffer's history. The [Back]
button does appear when there is a non-empty history, but going back and
then forward does not restore the font description.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27890: 26.0.50; describe-font does not use Help buffer history
2017-07-31 21:25 bug#27890: 26.0.50; describe-font does not use Help buffer history Alex
@ 2017-08-05 23:05 ` Alex
2017-08-06 0:21 ` npostavs
0 siblings, 1 reply; 8+ messages in thread
From: Alex @ 2017-08-05 23:05 UTC (permalink / raw)
To: 27890
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
Alex <agrambot@gmail.com> writes:
> describe-font does not add to the *Help* buffer's history. The [Back]
> button does appear when there is a non-empty history, but going back and
> then forward does not restore the font description.
Here's a patch for it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xref --]
[-- Type: text/x-diff, Size: 1355 bytes --]
From 658823b3a1adec25283d28e59710aa160afd7908 Mon Sep 17 00:00:00 2001
From: Alexander Gramiak <agrambot@gmail.com>
Date: Sat, 5 Aug 2017 16:09:54 -0600
Subject: [PATCH] Use help-mode xrefs in describe-font
* lisp/international/mule-diag.el (describe-font): Use help-setup-xref
(Bug#27890).
---
lisp/international/mule-diag.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/international/mule-diag.el b/lisp/international/mule-diag.el
index c274621f77..655a5ca6d4 100644
--- a/lisp/international/mule-diag.el
+++ b/lisp/international/mule-diag.el
@@ -838,7 +838,8 @@ describe-font
(interactive "sFont name (default current choice for ASCII chars): ")
(or (and window-system (fboundp 'fontset-list))
(error "No fonts being used"))
- (let (font-info)
+ (let ((xref-item (list #'describe-font fontname))
+ font-info)
(if (or (not fontname) (= (length fontname) 0))
(setq fontname (face-attribute 'default :font)))
(setq font-info (font-info fontname))
@@ -850,6 +851,7 @@ describe-font
;; this problem.
(message "No information about \"%s\"" (font-xlfd-name fontname))
(message "No matching font found"))
+ (help-setup-xref xref-item (called-interactively-p 'interactive))
(with-output-to-temp-buffer "*Help*"
(describe-font-internal font-info)))))
--
2.13.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* bug#27890: 26.0.50; describe-font does not use Help buffer history
2017-08-05 23:05 ` Alex
@ 2017-08-06 0:21 ` npostavs
2017-08-06 2:01 ` Alex
0 siblings, 1 reply; 8+ messages in thread
From: npostavs @ 2017-08-06 0:21 UTC (permalink / raw)
To: Alex; +Cc: 27890
tags 27890 + patch
quit
Alex <agrambot@gmail.com> writes:
> Alex <agrambot@gmail.com> writes:
>
>> describe-font does not add to the *Help* buffer's history. The [Back]
>> button does appear when there is a non-empty history, but going back and
>> then forward does not restore the font description.
>
> Here's a patch for it.
>
> + (let ((xref-item (list #'describe-font fontname))
[...]
> + (help-setup-xref xref-item (called-interactively-p 'interactive))
Looks fine, personally I wouldn't bother introducing that local
variable.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27890: 26.0.50; describe-font does not use Help buffer history
2017-08-06 0:21 ` npostavs
@ 2017-08-06 2:01 ` Alex
2017-08-06 3:24 ` Alex
2017-08-06 11:43 ` npostavs
0 siblings, 2 replies; 8+ messages in thread
From: Alex @ 2017-08-06 2:01 UTC (permalink / raw)
To: npostavs; +Cc: 27890
npostavs@users.sourceforge.net writes:
> tags 27890 + patch
> quit
>
> Alex <agrambot@gmail.com> writes:
>
>> Alex <agrambot@gmail.com> writes:
>>
>>> describe-font does not add to the *Help* buffer's history. The [Back]
>>> button does appear when there is a non-empty history, but going back and
>>> then forward does not restore the font description.
>>
>> Here's a patch for it.
>>
>> + (let ((xref-item (list #'describe-font fontname))
> [...]
>> + (help-setup-xref xref-item (called-interactively-p 'interactive))
>
> Looks fine, personally I wouldn't bother introducing that local
> variable.
I introduced that variable because the procedure conditionally sets
fontname if it's an empty sequence. As it stands, the procedure would
error without capturing that variable ahead of time due to `length' being
called on a font object.
I figured this was the simplest way around that problem. Do you have an
easier way in mind? I could perhaps change the setq line to instead set
fontname to (face-attribute 'default :family), which would allow for
removing the local variable safely.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27890: 26.0.50; describe-font does not use Help buffer history
2017-08-06 2:01 ` Alex
@ 2017-08-06 3:24 ` Alex
2017-08-06 11:43 ` npostavs
1 sibling, 0 replies; 8+ messages in thread
From: Alex @ 2017-08-06 3:24 UTC (permalink / raw)
To: npostavs; +Cc: 27890
Alex <agrambot@gmail.com> writes:
> npostavs@users.sourceforge.net writes:
>
>> tags 27890 + patch
>> quit
>>
>> Alex <agrambot@gmail.com> writes:
>>
>>> Here's a patch for it.
>>>
>>> + (let ((xref-item (list #'describe-font fontname))
>> [...]
>>> + (help-setup-xref xref-item (called-interactively-p 'interactive))
>>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.
>
> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.
I made a patch that does this, but it doesn't behave exactly the same.
(font-info (face-attribute 'default :family)) for me returns a font with
size/height 16/19, but (font-info (face-attribute 'default :font))
returns a font with size/height 15/18. I've tried this with multiple
fonts, and it happens with each one.
This seems like a bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#27890: 26.0.50; describe-font does not use Help buffer history
2017-08-06 2:01 ` Alex
2017-08-06 3:24 ` Alex
@ 2017-08-06 11:43 ` npostavs
2017-08-07 21:19 ` Alex
1 sibling, 1 reply; 8+ messages in thread
From: npostavs @ 2017-08-06 11:43 UTC (permalink / raw)
To: Alex; +Cc: 27890
Alex <agrambot@gmail.com> writes:
> npostavs@users.sourceforge.net writes:
>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.
Oops, right. I skimmed too quickly because your patch looked so simple.
> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.
No, let's not get bogged down in micro-optimization and just go with
what you had originally.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-08-08 23:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-31 21:25 bug#27890: 26.0.50; describe-font does not use Help buffer history Alex
2017-08-05 23:05 ` Alex
2017-08-06 0:21 ` npostavs
2017-08-06 2:01 ` Alex
2017-08-06 3:24 ` Alex
2017-08-06 11:43 ` npostavs
2017-08-07 21:19 ` Alex
2017-08-08 23:58 ` npostavs
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).