From: npostavs@users.sourceforge.net
To: Alex <agrambot@gmail.com>
Cc: 27890@debbugs.gnu.org
Subject: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sun, 06 Aug 2017 07:43:08 -0400 [thread overview]
Message-ID: <8737946hwz.fsf@users.sourceforge.net> (raw)
In-Reply-To: <873795wj2a.fsf@lylat> (Alex's message of "Sat, 05 Aug 2017 20:01:33 -0600")
Alex <agrambot@gmail.com> writes:
> npostavs@users.sourceforge.net writes:
>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.
Oops, right. I skimmed too quickly because your patch looked so simple.
> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.
No, let's not get bogged down in micro-optimization and just go with
what you had originally.
next prev parent reply other threads:[~2017-08-06 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 21:25 bug#27890: 26.0.50; describe-font does not use Help buffer history Alex
2017-08-05 23:05 ` Alex
2017-08-06 0:21 ` npostavs
2017-08-06 2:01 ` Alex
2017-08-06 3:24 ` Alex
2017-08-06 11:43 ` npostavs [this message]
2017-08-07 21:19 ` Alex
2017-08-08 23:58 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737946hwz.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=27890@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).