From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#25316: Patch for bug#25316: 26.0.50; Bugs in testcover-reinstrument Date: Tue, 03 Oct 2017 10:32:55 -0700 Message-ID: <873770rvaw.fsf@runbox.com> References: <87bmlybfjp.fsf@runbox.com> <87lgkwdzcm.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507052058 12652 195.159.176.226 (3 Oct 2017 17:34:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Oct 2017 17:34:18 +0000 (UTC) User-Agent: mu4e 0.9.18; emacs 26.0.60 Cc: 25316@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 03 19:34:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzR57-0002Pt-GC for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 19:34:09 +0200 Original-Received: from localhost ([::1]:59647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzR5E-0005Ue-K5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 13:34:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzR54-0005T0-5y for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 13:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzR50-0007v5-8T for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 13:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzR4z-0007uX-Qu for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 13:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dzR4z-0003Eh-L3 for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 13:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2017 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25316-submit@debbugs.gnu.org id=B25316.150705199012343 (code B ref 25316); Tue, 03 Oct 2017 17:34:01 +0000 Original-Received: (at 25316) by debbugs.gnu.org; 3 Oct 2017 17:33:10 +0000 Original-Received: from localhost ([127.0.0.1]:46698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzR4A-0003D1-6P for submit@debbugs.gnu.org; Tue, 03 Oct 2017 13:33:10 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:40916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzR47-0003Cp-Ie for 25316@debbugs.gnu.org; Tue, 03 Oct 2017 13:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to: Subject:Cc:To:From:References; bh=pF8YbuLTKi2HO3Qjtcwlnob26Q9YY8scM1Hka4o9fNk=; b=Y23k13m2Q7x9LPsFE/i7GZOFs7 j14Y3IHJdOnnKOgceMYypVlgj5uw4/MIRrP/s9CxwLx31nQrCxBIJJzWlyxIUifq80TzUxD2xW/vl lAVhSWdbmPTY5b0d04PiOFlFhu7bG6T6TbZlKAsjipbkvyiFlgII8vXsmCHIVHiDYCi8xl9XBwXq7 rs9y2YVgC2iD5kZ8P3E01aw29rsNHS1G+k9P5i2adc8Ukw9h1nzcJ/6Wbr6wppc9VwlLhsBdC8gFU V9nKXenhoUHIdKWqZIS7DdnliFYcVx4W2UxlTqLdi1fs737EQgNPO0nx/9xc+6EcqujD2AxGx4kar AIFinr6g==; Original-Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dzR45-0003u9-ST; Tue, 03 Oct 2017 19:33:05 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dzR3x-0001yV-Rf; Tue, 03 Oct 2017 19:32:58 +0200 In-reply-to: <87lgkwdzcm.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137851 Archived-At: Noam Postavsky writes: > Overriding the function-definition of edebug-before and edebug-after > doesn't seem very clean. It would be better to have an > edebug-before-function which is `funcall'ed I think (I know your patch > didn't introduce this, it just makes it more obvious. Perhaps it could > be addressed later). An advantage to using an overridden function-definition is that it makes backtraces of instrumented code easier to read. >> + ((or `(\` ,bq-form) `(\` . ,bq-form)) > > Isn't only the first of these is needed? (read "`foo") ;=> (\` foo) Yes, only the first is needed, so I'll fix this in both places.