unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 30594@debbugs.gnu.org
Subject: bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb
Date: Sat, 24 Feb 2018 21:56:51 +0100	[thread overview]
Message-ID: <87371qqf70.fsf@gmx.de> (raw)
In-Reply-To: <20180224180640.29490-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Sat, 24 Feb 2018 19:06:40 +0100")

Mathieu Othacehe <m.othacehe@gmail.com> writes:

Hi Mathieu,

> Support some Android derived systems where 'ls' binary is provided by
> GNU Coreutils.

Thanks for this! I cannot test myself,  so I'll trust that it works
proper. However,

> +     ;; Support Android derived systems where "ls" command is provided
> +     ;; by GNU Coreutils. Force "ls" to print one column and set
> +     ;; time-style to imitate other "ls" flavours.
> +     ((tramp-adb-send-command-and-check vec "ls --help | grep coreutils")
> +      "env COLUMNS=1 ls --time-style=long-iso")

I believe it is not future-safe to depend on any string in --help
output. The better approach is to test, whether the ls command accepts
the --time-style=long-iso argument. Something like

((tramp-adb-send-command-and-check vec "ls --time-style=long-iso /dev/null")

Could you pls check, whether it works like this?

Best regards, Michael.





  reply	other threads:[~2018-02-24 20:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 18:06 bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb Mathieu Othacehe
2018-02-24 20:56 ` Michael Albinus [this message]
2018-02-24 21:04   ` Michael Albinus
2018-02-25  9:42     ` Mathieu Othacehe
2018-02-25 10:13       ` Andreas Schwab
2018-02-25 10:48         ` Mathieu Othacehe
2018-02-25 10:57           ` Michael Albinus
2018-02-25 11:18             ` Mathieu Othacehe
2018-02-26 15:52               ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87371qqf70.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=30594@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).