From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#31355: 26.1; [PATCH] Fix remote-host/tramp directory tracking for shells in `term' buffers Date: Thu, 03 May 2018 16:04:58 +0200 Message-ID: <8736z8u96d.fsf@gmx.de> References: <3d76a935822f56f94705b1f59421a00a@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1525356257 14358 195.159.176.226 (3 May 2018 14:04:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 14:04:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31355@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 16:04:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEEqD-0003b3-6g for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 16:04:13 +0200 Original-Received: from localhost ([::1]:56545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEEsI-0005Ov-6k for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 10:06:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEEs3-0005Ob-2j for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:06:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEEry-0001qM-BL for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEEry-0001q9-8i for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEErx-0007n5-Pe for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31355-submit@debbugs.gnu.org id=B31355.152535631729893 (code B ref 31355); Thu, 03 May 2018 14:06:01 +0000 Original-Received: (at 31355) by debbugs.gnu.org; 3 May 2018 14:05:17 +0000 Original-Received: from localhost ([127.0.0.1]:48333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEErF-0007m5-2B for submit@debbugs.gnu.org; Thu, 03 May 2018 10:05:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:59689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEErD-0007ls-AX for 31355@debbugs.gnu.org; Thu, 03 May 2018 10:05:15 -0400 Original-Received: from detlef.gmx.de ([212.86.52.157]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mcgur-1ewQt30r1l-00Hstj; Thu, 03 May 2018 16:05:00 +0200 In-Reply-To: <3d76a935822f56f94705b1f59421a00a@webmail.orcon.net.nz> (Phil Sainty's message of "Fri, 04 May 2018 01:52:09 +1200") X-Provags-ID: V03:K1:58Aow1Jjc7bhgFdrGEAIOigAAikWIdRvEjGGjCAgEx7OHGcZKMT 0O4V7STOeJBJikEjGNXLJQSSIPanpoG7DTqjjOqC4WGdEFco/if4Phs6Tdv/rVogGJ8C2r0 jzy3tINRV8c/HLMoVENcdqW7mXij+mYNk93jElLWYsc8rAQM3fAVaJJ29uOseADEYGM50+2 1IcqrKSit3zQEmHXYqhCw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0P8yQLrVDuw=:KeZ1V2PygUcTRSWUn4tjRX Aio5P/eSjP9K7AioOasCwUqQBgjLDrp+2SedNf6V5/LnOgnH/oW7SMJafmCWQ1mQNectfGFm7 qO6Hk2xz79f/1BPlSwPNE7ucVdfywo5/L5sgu0FjXkMPiE3DAEncnDhWmwdZSzMkLzdWrtbkf p9+EqIApRSv7wA3Doq2RMjXukM3pj/sr3SMfHbgkGelY9xAe3Vh4bFB/eCI1CrhPzvuriD8R5 aNGbs6xZRtJXwv+KU6gD0S2uhARkrrVIkFyH3ZacwXdjJYYXEehj4M9vmgbvhGcFdP/0zN4f/ D9RNt6O9AhaWkcuj9y+5rE1N9eBFxTbH0LqCJ5O581FqTxVvCK1/XmVeNIyj9ckBr6bM4UbLK 2TjUYHMbj87Yb5QJjY65Vg0rdCM/8ujLkFBO0a9O6QwBNrZ3ks9r6cOii6Ii7u3CsL8l0uQz4 8wy0oaxAL3uKbM4kQLjsSkxWlhVhFumdkkCm/o2V7nfdACDer55DvURVwESWgPG8VpenCj9Wg hG2wyOvIAcrtQKoAwamcsShb0Z27eG0PI8ecckAysRiCEs+jgc/Wmmkz+TPGPtRWnL5aPqhHg iUmIA0wmQad4hzzvfkCrNdqB8e73cE+P/YOHmayJmIeg5zXWdzx/uWJVqMSyJ7GYZc/Os1qeX ROaWZd01fC/lZJync02OzS9v8/X+eFR71UuCpGW79lQgqM+t/X6YevgpwOTUcEEuIr0i1+pfW wadogx6YyBe1fPYU09skxyNhP3VRRJjAz8dTt2KL+uk4etV3sA8krEMe09f4NgJ3z12CCDTH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145971 Archived-At: Phil Sainty writes: Hi Phil, > With tramp methods now being mandatory, the term.el directory tracking > was generating invalid tramp paths on remote hosts. > > I've rolled a patch for this (along with some very minor improvements > to the related commentary) in which I'm hard-coding the "ssh" method. > I'm not sure whether that's the ideal fix, but I suspect it's likely > to do the trick for most people, whereas the current code won't work > at all. Thanks for this. I haven't tested, just a short comment: > @@ -2753,8 +2756,8 @@ term-handle-ansi-terminal-messages > (string= term-ansi-at-user (user-real-login-name))) > (expand-file-name term-ansi-at-dir) > (if (string= term-ansi-at-user (user-real-login-name)) > - (concat "/" term-ansi-at-host ":" term-ansi-at-dir) > - (concat "/" term-ansi-at-user "@" term-ansi-at-host ":" > + (concat "/ssh:" term-ansi-at-host ":" term-ansi-at-dir) > + (concat "/ssh:" term-ansi-at-user "@" term-ansi-at-host ":" I believe it is always save to use term-ansi-at-user. There's no need to check, whether it is equal to (user-real-login-name). Furthermore, I wouldn't hard-code "ssh". People might have other preferences, and on some systems it doesn't work. Think about Emacs running on MS WIndows, where "plink" is used instead of "ssh". Just take "-" as method, this is a notation to apply user's default (Tramp) method. > -Phil Best regards, Michael.