From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33263: 27.0.50; Tidying up Gnus modes Date: Tue, 06 Nov 2018 08:27:56 -0500 Message-ID: <8736seibdv.fsf@gmail.com> References: <877ehs1bgq.fsf@ericabrahamsen.net> <875zxbipby.fsf@gmail.com> <87o9b3za3p.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541511124 32507 195.159.176.226 (6 Nov 2018 13:32:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 13:32:04 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 33263@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 14:32:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1SZ-0008Ko-S4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 14:31:59 +0100 Original-Received: from localhost ([::1]:41147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1Ug-0007FN-7x for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 08:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1Pm-0001lw-71 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:29:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK1Ph-0008FH-TV for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:29:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK1Ph-0008Ez-P4 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gK1Ph-00065e-KE for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 13:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33263 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33263-submit@debbugs.gnu.org id=B33263.154151088623345 (code B ref 33263); Tue, 06 Nov 2018 13:29:01 +0000 Original-Received: (at 33263) by debbugs.gnu.org; 6 Nov 2018 13:28:06 +0000 Original-Received: from localhost ([127.0.0.1]:36133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1Oo-00064S-0c for submit@debbugs.gnu.org; Tue, 06 Nov 2018 08:28:06 -0500 Original-Received: from mail-it1-f173.google.com ([209.85.166.173]:40572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1Om-00063z-L4 for 33263@debbugs.gnu.org; Tue, 06 Nov 2018 08:28:04 -0500 Original-Received: by mail-it1-f173.google.com with SMTP id e11so14276662itl.5 for <33263@debbugs.gnu.org>; Tue, 06 Nov 2018 05:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=C9CyAdJF7ca+zWjO2MkiFNwCSDP3XOWjsYG/9zHtF+k=; b=qiJeMffYyb4kC9V0D18ia2rabiAJ5xHb94leqIljnsYgSw+jTy2niuRE116SRXjXKI U/QlpE8HnbraITrZZ/maO9HJNFHbPfkQMlWESwBTeOcejlTf5QzrvmVO9FzFQ8HavhPt 6C7cpdSZrI7Bn/LWV7DV5PxHEzusBpSsV3BjzkRi4AkOnNB2G3vT3plFDAcArHyh5Dnt NzMRcbNsZfXKdOQbhJTWzR/z8f6HfA21klrXVQEn66Fp1YMRckmiMUiWWjW3/HhVHZ8K lNxYC2FcXk4vNSTXbvHgasbX7V7PZG/gicYAxwGmKCg/znhv2bqUOVWqL5fDR0zrTDVx 6jrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=C9CyAdJF7ca+zWjO2MkiFNwCSDP3XOWjsYG/9zHtF+k=; b=qjIwaw6S2P7XJWGYWAQbhmIx0f1waOrN3Oahgmp2mJKCB4pzd6FgYWvgoCx9Xd4bif U94s8ASAjslRaonlz8Kbso+SbYFuOV2hTzYJTKoQxuneoeXrIFhzrZSUVURJVL4nEbTZ h+nXrGX9UCLBuxA9JldlkrOxDWUd1/GtaN+9hCqSL4Uxn4DCkNqPQni01bgkfZoht6Nk iDDKkUxPMXUiJVeZwn15X3d9PkNEzbA3NLvETA2hpOth0h90vyaX5yVGH31sBnh0UHlB Z4n3TUFctO2BikbbO2W1Oy2xkigLRaANSDnpBSXSTUYprpi5MPUrS5F0nEHwQlL1LOfl iT5g== X-Gm-Message-State: AGRZ1gLqlF2++4AXxkWHcDN1qX0WALJxTRu8TFlgRMTGn5XYfcr+EaRf RfQ1ra2S7HIc0c3bU4XPiscjiClo X-Google-Smtp-Source: AJdET5cix+2e7nPG3vNM4Yyp0CcWmtAuOLQIEi3wQfqOvigSTNpaJe0LfzU6eiJvtS1ICn3YqqBIjw== X-Received: by 2002:a24:7012:: with SMTP id f18-v6mr1817672itc.87.1541510878900; Tue, 06 Nov 2018 05:27:58 -0800 (PST) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p78-v6sm791953itp.32.2018.11.06.05.27.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 05:27:57 -0800 (PST) In-Reply-To: <87o9b3za3p.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 05 Nov 2018 09:51:22 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152100 Archived-At: Eric Abrahamsen writes: > Noam Postavsky writes: > >> Eric Abrahamsen writes: >> >>> +(defvar gnus-browse-mode-map (make-keymap)) >>> >>> (unless gnus-browse-mode-map >>> - (setq gnus-browse-mode-map (make-keymap)) >>> + (defvar gnus-browse-mode-map (make-keymap)) >> >> This doesn't look right. > > Hmm, you're right, I think I got confused there. TBH I don't really know > why these things are wrapped in `unless', but I think what should have > happened is that `gnus-browse-mode-map' is first defvar'ed to nil, and > later setq'ed to (make-keymap). The usual idiom for this is (defvar gnus-browse-mode-map (let ((map (make-sparse-keymap))) (define-key map ...) ... map)) It seems that (the expansion of) gnus-define-keys relies on dynamic binding of the map variable (i.e., it must be called after the defvar, not inside), so that's the reason to split in two parts.