bug#34065: 26.1; Make edebug-eval-expression support code completion

[Federico Tedin <federicotedin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Xu Chunyang <mail@xuchunyang.me> writes:

> When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike
> M-: (eval-expression). So I wonder if edebug-eval-expression can behave
> like eval-expression, I guess simply replacing read-from-minibuffer with
> read--expression should work, though I've not tried.

I've created a small patch which replaces `read-from-minibuffer' for
`read--expression' in `edebug-eval-expression'. I would appreciate it if
a maintainer could take a quick look.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1069 bytes --]

From ce40da7d2b254be1eee5e5f96d674504525f9b72 Mon Sep 17 00:00:00 2001
From: Federico Tedin <federicotedin@gmail.com>
Date: Sat, 19 Jan 2019 23:02:36 -0300
Subject: [PATCH 1/1] Use read--expression to read expressions in Edebug

* lisp/emacs-lisp/edebug.el: Use read--expression instead of
  read-from-minibuffer to read Emacs Elisp expressions (Bug#34065).
---
 lisp/emacs-lisp/edebug.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 2cd8e48d6e..8b4cb1adc7 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -3602,9 +3602,7 @@ edebug-eval-expression
   "Evaluate an expression in the outside environment.
 If interactive, prompt for the expression.
 Print result in minibuffer."
-  (interactive (list (read-from-minibuffer
-		      "Eval: " nil read-expression-map t
-		      'read-expression-history)))
+  (interactive (list (read--expression "Eval: ")))
   (princ
    (edebug-outside-excursion
     (setq values (cons (edebug-eval expr) values))
-- 
2.17.1