From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11) Date: Tue, 09 Apr 2019 07:52:24 -0400 Message-ID: <8736mrcs5j.fsf@gmail.com> References: <08e7108149ce2374fd0c9b7fc3e6ae38@reckondigital.com> <40839b67-bce7-4a01-89f1-c14643b18b32@default> <80f4335be923e21fe782780c6812a03f@reckondigital.com> <878sxd248k.fsf@mail.linkov.net> <82347809b60dfc4e18a822d2d604475c@reckondigital.com> <87mul0wacr.fsf@mail.linkov.net> <336a681ce53ad7623fc5f98936577d82@reckondigital.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31897"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 34621@debbugs.gnu.org, juri@linkov.net To: Christopher Thorne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 13:53:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDpJP-0008CM-QT for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 13:53:11 +0200 Original-Received: from localhost ([127.0.0.1]:39592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDpJO-0004iU-Oy for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 07:53:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDpJH-0004iP-QU for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 07:53:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDpJG-0000f1-TA for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 07:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDpJG-0000eh-M5 for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 07:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDpJG-0005C5-AN for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 07:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2019 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34621-submit@debbugs.gnu.org id=B34621.155481075419929 (code B ref 34621); Tue, 09 Apr 2019 11:53:02 +0000 Original-Received: (at 34621) by debbugs.gnu.org; 9 Apr 2019 11:52:34 +0000 Original-Received: from localhost ([127.0.0.1]:50648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDpIn-0005BN-Rd for submit@debbugs.gnu.org; Tue, 09 Apr 2019 07:52:34 -0400 Original-Received: from mail-qk1-f195.google.com ([209.85.222.195]:35129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDpIl-0005BB-TI for 34621@debbugs.gnu.org; Tue, 09 Apr 2019 07:52:32 -0400 Original-Received: by mail-qk1-f195.google.com with SMTP id a71so10001363qkg.2 for <34621@debbugs.gnu.org>; Tue, 09 Apr 2019 04:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7U8+OGNMVR+1VbVjXPIcxutdGW1jo15AeelVHB7IivE=; b=vOFTbFnSp9bXRx1nSSdjWSiXQghXdU+KCGea0hiGXqUKojzX4UrypKVCHTRAqnd2DE Br/Jd0apLYDXfTPnjmvKZZxMAd2nh/h5NL73yDYZkRfP/NjGb9lfbZuXk2blJGdWZXyU csdnXZ7ycBxQE9678RfsyxlSrhdfod6xUIXV5vhVB6fNBrh/FbSihPUEnuhsl2LiE+TQ +kNThs2r5Nx+pvo4UeMvi6BSGPMNmVeL65I2hR4Wmo/Ug50b+rm4QKl4r4kke1wlAEoO oMmkr+RSaiB5e+LFMWAcBcQ5Vi2AwIsVb+EG/yE8kHR9KBZCyDVPN/eereRkWpMZ0teD 4OvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7U8+OGNMVR+1VbVjXPIcxutdGW1jo15AeelVHB7IivE=; b=emsMfQl3AOZTldUETWaoNGroRvO/jFlZNAMCscLbhhLUrAc9CxvyUyMoHgazVUNg0f WtqN4f3znIi1F02Iss9LzuXJtIiOFFY2t7x3EIKLnGElnImn5XQqSYlhDN5LwOAjVLzv mDxIPQx+uVWbyphviZjQJ7f7IiISPS1ECuZlIe8F0duUeGtm18CxAZDyEeOQry/8fq6M UZieu4UibT9mKQlkqPMvy0KF91P3Mv3WO1vaTD7lK3AUI1r9iTj47xEmc3PTSWBd21m9 fhv/+/0qjvmMZcFtmdBAFIOozuSCjQGGsVbuHf0fjJvRwcAs3IZJl32QruHzJoJELPGY zPEw== X-Gm-Message-State: APjAAAVbd87SypZjRN8W8rYyZBJ6/G2K1J0tEdS1Xc/TAi3xRKN9IKFE 50okOuEOVYfisLV3Dv82uY7sWPsS X-Google-Smtp-Source: APXvYqy4S/QGOVKwmvoNNEfMjlnL/b5mT0ruwM0NkxB5fOruFlqQ3Qct9KEsqOgctfE13Z13Wy45hw== X-Received: by 2002:a05:620a:1472:: with SMTP id j18mr27387449qkl.63.1554810746330; Tue, 09 Apr 2019 04:52:26 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x28sm21741738qtx.71.2019.04.09.04.52.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 04:52:25 -0700 (PDT) In-Reply-To: <336a681ce53ad7623fc5f98936577d82@reckondigital.com> (Christopher Thorne's message of "Tue, 09 Apr 2019 12:09:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157410 Archived-At: > + (let* ((file-name-at-point (run-hook-with-args-until-success > 'file-name-at-point-functions)) Just a minor suggestion meta suggestion: post your patches by attaching the output from 'git format-patch', rather than inlining the output of git diff. That will avoid patch corruption due to line-wrapping, like in the above quote (although that line is also a bit long, and you should break it manually). > Changelog entry: > * lisp/progmodes/grep.el (grep-read-files): Allow major modes to > define file name to use for default search pattern > * lisp/dired.el (dired-grep-file-name-for-default-pattern): Use file > at point > for grep file name pattern And the ChangeLog entry then goes in the git commit message. It's much easier for other people to apply your patch that way.