From: Noam Postavsky <npostavs@gmail.com>
To: Christopher Thorne <c.thorne@reckondigital.com>
Cc: 34621@debbugs.gnu.org, juri@linkov.net
Subject: bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11)
Date: Tue, 09 Apr 2019 07:52:24 -0400 [thread overview]
Message-ID: <8736mrcs5j.fsf@gmail.com> (raw)
In-Reply-To: <336a681ce53ad7623fc5f98936577d82@reckondigital.com> (Christopher Thorne's message of "Tue, 09 Apr 2019 12:09:27 +0100")
> + (let* ((file-name-at-point (run-hook-with-args-until-success
> 'file-name-at-point-functions))
Just a minor suggestion meta suggestion: post your patches by attaching
the output from 'git format-patch', rather than inlining the output of
git diff. That will avoid patch corruption due to line-wrapping, like
in the above quote (although that line is also a bit long, and you
should break it manually).
> Changelog entry:
> * lisp/progmodes/grep.el (grep-read-files): Allow major modes to
> define file name to use for default search pattern
> * lisp/dired.el (dired-grep-file-name-for-default-pattern): Use file
> at point
> for grep file name pattern
And the ChangeLog entry then goes in the git commit message. It's much
easier for other people to apply your patch that way.
next prev parent reply other threads:[~2019-04-09 11:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 17:29 bug#34621: [PATCH] lisp/progmodes/grep.el (grep-read-files): Add file-directory-p check Christopher Thorne
2019-03-04 11:13 ` bug#34621: Patch Update Christopher Thorne
2019-03-04 15:26 ` Drew Adams
2019-03-05 10:49 ` Christopher Thorne
2019-03-05 17:48 ` Drew Adams
2019-03-05 18:22 ` Christopher Thorne
2019-03-05 18:44 ` Drew Adams
2019-03-06 11:10 ` Christopher Thorne
2019-03-17 21:28 ` bug#34621: [PATCH] lisp/progmodes/grep.el (grep-read-files): Add file-directory-p check Juri Linkov
2019-04-08 10:41 ` bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11) Christopher Thorne
2019-04-08 19:44 ` Juri Linkov
2019-04-09 11:09 ` Christopher Thorne
2019-04-09 11:52 ` Noam Postavsky [this message]
2019-04-09 12:23 ` Christopher Thorne
2019-04-09 14:18 ` Eli Zaretskii
2019-04-09 14:32 ` Christopher Thorne
2019-04-09 20:32 ` Juri Linkov
2019-04-10 10:42 ` Christopher Thorne
2019-04-10 20:37 ` Juri Linkov
2019-04-11 20:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736mrcs5j.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=34621@debbugs.gnu.org \
--cc=c.thorne@reckondigital.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).